From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] Move various PCI IDs to header file Date: Sat, 13 May 2006 00:29:39 -0400 Message-ID: <446560B3.10301@garzik.org> References: <20060504180614.X88573@chenjesu.americas.sgi.com> <20060504173722.028c2b24.rdunlap@xenotime.net> <445AE690.5030700@sgi.com> <20060505133437.GA24268@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:49122 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1750861AbWEME3n (ORCPT ); Sat, 13 May 2006 00:29:43 -0400 In-Reply-To: <20060505133437.GA24268@kroah.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Greg KH Cc: Jes Sorensen , "Randy.Dunlap" , Brent Casavant , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, akpm@osdl.org, jeremy@sgi.com (since I was an instigator here...) Greg KH wrote: > No, I agree with your patch, as you are having to reference the ids from > 2 different files. So because of that, I feel it's ok to have those ids > in the pci_id.h file. Agreed. > Yes, the wording in the documentation file should be cleaned up a bit to > state this a bit better... Agreed. Jeff