Re: [PATCHSET 03/11] new EH implementation, take 3

[Tejun Heo <htejun@gmail.com>]

Jeff Garzik wrote:
> Tejun Heo wrote:
>> This is part of patchset series described in [T].
>>
>> This is the third take of new-EH-implementation patchset.  Changes
>> from the last take[L] are
> [...]
>> [T] http://article.gmane.org/gmane.linux.ide/9957
>> [L] http://article.gmane.org/gmane.linux.ide/9540
>> [1] http://article.gmane.org/gmane.linux.ide/9959
>> [2] http://article.gmane.org/gmane.linux.ide/9984
> 
> Aside from one minor requested change, this patchset is ACK'd, but with 
> a few comments and worries noted.
> 
> Once this goes in we need to move all the drivers over as soon as 
> possible, and get them all re-tested.
> 

I will be a lot of work.  As new EH uses features unused before, it 
sometimes exposes new hardware problems (things like sata_sil24 port 
wide IRQ plugging doesn't really work).  Those problems take time to 
diagnose and work around.  Also, different strains of a controller might 
show different symptoms.  So, we need a lot of testing.

I agree that drivers should be converted ASAP but honestly don't know 
how fast those can be done; however, libata will continue to work with 
all the old-EH drivers as well as before, so we have some headroom.

-- 
tejun