From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [RFT] major libata update Date: Mon, 15 May 2006 14:15:12 -0400 Message-ID: <4468C530.6080409@garzik.org> References: <20060515170006.GA29555@havoc.gtf.org> <20060515101831.0e38d131.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:17092 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S965025AbWEOSPP (ORCPT ); Mon, 15 May 2006 14:15:15 -0400 In-Reply-To: <20060515101831.0e38d131.akpm@osdl.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Andrew Morton Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, torvalds@osdl.org Andrew Morton wrote: > I'd be a little concerned with that merge plan at this time - we have a lot > of sata bug reports banked up and afaict a pretty low fixup rate. Then > again, these patches might fix some of those bugs... > > I guess if we can get it all in early (which is only a couple of weeks > away!) and you and Tejun will have time set aside to work on problems then > OK. But.... As you can see from the list just sent, the improved error handling will give libata much greater ability to diagnose "controller is being weird" type situations, which is a lot of what the relevant bug reports need. After reviewing those bug reports, I see a couple oopses -- caused by BUG()-style code, and fixed in this update -- and one data corruption which persists on Sil 311x on rare motherboards. The rest are either addressed with the improved error handling, or are ATAPI + VIA AFAICS. Jeff