From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [Fwd: [RFT] major libata update]
Date: Tue, 16 May 2006 12:37:55 -0400
Message-ID: <4469FFE3.3020009@garzik.org>
References: <4468B596.9090508@garzik.org>	 <1147789098.3505.19.camel@mulgrave.il.steeleye.com>	 <4469F2B2.703@garzik.org>	 <1147794708.3505.30.camel@mulgrave.il.steeleye.com>	 <4469F906.7040602@gmail.com> <1147796999.3505.42.camel@mulgrave.il.steeleye.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-scsi-owner@vger.kernel.org>
In-Reply-To: <1147796999.3505.42.camel@mulgrave.il.steeleye.com>
Sender: linux-scsi-owner@vger.kernel.org
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Tejun Heo <htejun@gmail.com>, SCSI Mailing List <linux-scsi@vger.kernel.org>, "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>, Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
List-Id: linux-ide@vger.kernel.org

James Bottomley wrote:
> On Wed, 2006-05-17 at 01:08 +0900, Tejun Heo wrote:
>> It's handled the same way shost->host_failed is handled.
>> scsi_device_unbusy() wakes it up when the condition is met.
> 
> That's the piece I hadn't spotted, yet ... thanks.  That will do it.
> 
> could you move ata_schedule_scsi_eh to scsi_error (with the appropriate
> API rename).  That way the SCSI state model changes aren't in libata
> (and no-one else who wants to use this has to open code the
> ata_schedule_scsi_eh API).

ACK