linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Jens Axboe <axboe@suse.de>
Cc: "zhao, forrest" <forrest.zhao@intel.com>,
	Tejun Heo <htejun@gmail.com>,
	linux-ide@vger.kernel.org
Subject: Re: ata_piix resume from S3 on T43P failed
Date: Wed, 17 May 2006 08:56:22 -0400	[thread overview]
Message-ID: <446B1D76.6010303@garzik.org> (raw)
In-Reply-To: <20060517110328.GM4197@suse.de>

Jens Axboe wrote:
> I think Hugh traced it down to a unrelated timer change. The above
> really wants to wait for BUSY clear, perhaps the best solution would be
> to have piix device its own ata_piix_device_resume() that first waits
> for BUSY clear, then calls ata_device_resume().

Close...  all devices should wait for libata to signal that the bus is 
ready to be talked to.  For some that's waiting for BSY to clear, for 
others that's checking the SATA bus.

	Jeff



  reply	other threads:[~2006-05-17 12:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-11  8:05 ata_piix resume from S3 on T43P failed zhao, forrest
2006-05-11  8:31 ` Tejun Heo
2006-05-11  8:35   ` Tejun Heo
2006-05-11  9:46     ` zhao, forrest
2006-05-11 10:39       ` Tejun Heo
2006-05-12  5:02         ` zhao, forrest
2006-05-11 10:55       ` Jens Axboe
2006-05-12  5:51         ` zhao, forrest
2006-05-12 10:17           ` Jens Axboe
2006-05-12 10:56             ` Tejun Heo
2006-05-16  3:56             ` zhao, forrest
2006-05-17 11:03               ` Jens Axboe
2006-05-17 12:56                 ` Jeff Garzik [this message]
2006-05-17 13:02                   ` Jens Axboe
2006-05-22  7:32                     ` Jeff Garzik
2006-05-13  4:19   ` Jeff Garzik
2006-05-16  1:58     ` zhao, forrest

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=446B1D76.6010303@garzik.org \
    --to=jeff@garzik.org \
    --cc=axboe@suse.de \
    --cc=forrest.zhao@intel.com \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).