[ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Tejun Heo]

Hello, all.

Lately libata has been going through a lot of changes and even more
are around the corner.  I've been working on error handling and
advanced SATA features for quite sometime now, and, finally, patches
have been finalized and submitted for review a few days ago.

2.6.18 is the target for mainline merge.  As there is quite some time
between now and 2.6.18, I have made patches to update the current
stable kernel to support the new features so that they can receive
wider testing and interested people don't have to wait too long.  I
intend to maintain these patches through 2.6.16 and 17 until the
mainline merge happens.

Added new features are

* New error handling
* IRQ driven PIO (from Albert Lee)
* SATA NCQ support
* Hotplug support
* Port Multiplier support

The following drivers support new features.

ata_piix:	new EH, irq-pio, warmplug (hardware restriction)
sata_sil:	new EH, irq-pio, hotplug
ahci:		new EH, irq-pio, NCQ, hotplug
sata_sil24:	new EH, irq-pio, NCQ, hotplug, Port Multiplier

More info can be found at the following URL.

 http://home-tj.org/wiki/index.php/Libata-tj-stable

Patches against v2.6.16.16 is avaialbe at the following URL.

 http://home-tj.org/files/libata-tj-stable/libata-tj-2.6.16.16-20060512.tar.bz2

Please read README carefully before testing the patches.  Keep in mind
that these are still quite experimental and not ready for production
use.

Thanks.

-- 
tejun

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Mikael Pettersson]

On Fri, 12 May 2006 22:24:37 +0900, Tejun Heo wrote:
>The following drivers support new features.
>
>ata_piix:	new EH, irq-pio, warmplug (hardware restriction)
>sata_sil:	new EH, irq-pio, hotplug
>ahci:		new EH, irq-pio, NCQ, hotplug
>sata_sil24:	new EH, irq-pio, NCQ, hotplug, Port Multiplier

If you were to add new EH and NCQ support to sata_promise,
then I'd test it on my News server.

/Mikael

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Randy.Dunlap]

On Fri, 12 May 2006 22:24:37 +0900 Tejun Heo wrote:

> Hello, all.
> 
> Lately libata has been going through a lot of changes and even more
> are around the corner.  I've been working on error handling and
> advanced SATA features for quite sometime now, and, finally, patches
> have been finalized and submitted for review a few days ago.
> 
> 2.6.18 is the target for mainline merge.  As there is quite some time
> between now and 2.6.18, I have made patches to update the current
> stable kernel to support the new features so that they can receive
> wider testing and interested people don't have to wait too long.  I
> intend to maintain these patches through 2.6.16 and 17 until the
> mainline merge happens.
> 
> Added new features are
> 
> * New error handling
> * IRQ driven PIO (from Albert Lee)
> * SATA NCQ support
> * Hotplug support
> * Port Multiplier support

BTW, we often use PM to mean Power Management.
Could we find a different acronym for Port Multiplier support,
such as PMS or PX or PXS?

---
~Randy

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Stefan Smietanowski]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

Randy.Dunlap wrote:
>>
>>* New error handling
>>* IRQ driven PIO (from Albert Lee)
>>* SATA NCQ support
>>* Hotplug support
>>* Port Multiplier support
> 
> 
> BTW, we often use PM to mean Power Management.
> Could we find a different acronym for Port Multiplier support,
> such as PMS or PX or PXS?

Ok, maybe not PMS ?

Can you imagine a bug report from someone that "has problem with PMS"?
:)

// Stefan

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 253 bytes --]

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Tejun Heo]

Stefan Smietanowski wrote:
> Randy.Dunlap wrote:
>>> * New error handling
>>> * IRQ driven PIO (from Albert Lee)
>>> * SATA NCQ support
>>> * Hotplug support
>>> * Port Multiplier support
>>
>> BTW, we often use PM to mean Power Management.
>> Could we find a different acronym for Port Multiplier support,
>> such as PMS or PX or PXS?
> 
> Ok, maybe not PMS ?
> 
> Can you imagine a bug report from someone that "has problem with PMS"?
> :)
> 

Would be fun though.  :)

I thought about using another acronym for port multiplier too.  But the 
spec uses that acronym all over the place, PM, PMP (Port Multiplier 
Portnumber), which reminds me of USB full/high speed fiasco.

Urghh... I thought we could use power for power management inside libata 
but that might be a bad idea.  So, PMS?

-- 
tejun

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Tejun Heo]

Mikael Pettersson wrote:
> On Fri, 12 May 2006 22:24:37 +0900, Tejun Heo wrote:
>> The following drivers support new features.
>>
>> ata_piix:	new EH, irq-pio, warmplug (hardware restriction)
>> sata_sil:	new EH, irq-pio, hotplug
>> ahci:		new EH, irq-pio, NCQ, hotplug
>> sata_sil24:	new EH, irq-pio, NCQ, hotplug, Port Multiplier
> 
> If you were to add new EH and NCQ support to sata_promise,
> then I'd test it on my News server.
> 

I have a promise card and played with it a little bit but I don't have
access to hardware doc.  So...

-- 
tejun

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Stefan Smietanowski]

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

Tejun Heo wrote:
> Stefan Smietanowski wrote:
> 
>> Randy.Dunlap wrote:
>>
>>>> * New error handling
>>>> * IRQ driven PIO (from Albert Lee)
>>>> * SATA NCQ support
>>>> * Hotplug support
>>>> * Port Multiplier support
>>>
>>>
>>> BTW, we often use PM to mean Power Management.
>>> Could we find a different acronym for Port Multiplier support,
>>> such as PMS or PX or PXS?
>>
>>
>> Ok, maybe not PMS ?
>>
>> Can you imagine a bug report from someone that "has problem with PMS"?
>> :)
>>
> 
> Would be fun though.  :)
> 
> I thought about using another acronym for port multiplier too.  But the
> spec uses that acronym all over the place, PM, PMP (Port Multiplier
> Portnumber), which reminds me of USB full/high speed fiasco.
> 
> Urghh... I thought we could use power for power management inside libata
> but that might be a bad idea.  So, PMS?

Actually, pmup?

Sort of describes what it is at the same time. (Alot easier to figure
out what pmup is than what pms is (in a computer :))

// Stefan

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 253 bytes --]

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Matthew Frost]

Stefan Smietanowski wrote:
> Tejun Heo wrote:
>> Stefan Smietanowski wrote:
>>
>>> Randy.Dunlap wrote:
>>>
>>>>> * New error handling
>>>>> * IRQ driven PIO (from Albert Lee)
>>>>> * SATA NCQ support
>>>>> * Hotplug support
>>>>> * Port Multiplier support
>>>>
>>>> BTW, we often use PM to mean Power Management.
>>>> Could we find a different acronym for Port Multiplier support,
>>>> such as PMS or PX or PXS?
>>>
>>> Ok, maybe not PMS ?
>>>
>>> Can you imagine a bug report from someone that "has problem with PMS"?
>>> :)
>>>
>> Would be fun though.  :)
>>
>> I thought about using another acronym for port multiplier too.  But the
>> spec uses that acronym all over the place, PM, PMP (Port Multiplier
>> Portnumber), which reminds me of USB full/high speed fiasco.
>>
>> Urghh... I thought we could use power for power management inside libata
>> but that might be a bad idea.  So, PMS?
> 
> Actually, pmup?
> 
> Sort of describes what it is at the same time. (Alot easier to figure
> out what pmup is than what pms is (in a computer :))
> 

Or PMUL?  MUL is in common usage for the arithmetic multiply sense; 
wouldn't it make sense in the Port Multiplier sense?  Would it get too 
confused with FPMUL?  Too much like an arithmetic operator?

> // Stefan

Matt

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Jeff Garzik]

Tejun Heo wrote:
> Mikael Pettersson wrote:
>> On Fri, 12 May 2006 22:24:37 +0900, Tejun Heo wrote:
>>> The following drivers support new features.
>>>
>>> ata_piix:	new EH, irq-pio, warmplug (hardware restriction)
>>> sata_sil:	new EH, irq-pio, hotplug
>>> ahci:		new EH, irq-pio, NCQ, hotplug
>>> sata_sil24:	new EH, irq-pio, NCQ, hotplug, Port Multiplier
>> If you were to add new EH and NCQ support to sata_promise,
>> then I'd test it on my News server.
>>
> 
> I have a promise card and played with it a little bit but I don't have
> access to hardware doc.  So...

I have Promise NCQ info, just waiting for the chance to use it :)

Plus I have a nagging suspicion that the SATA II cards have a few
differences from the SATA I cards that have yet to be coded into
sata_promise.c.

	Jeff

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Jeff Garzik]

Tejun Heo wrote:
> Stefan Smietanowski wrote:
>> Randy.Dunlap wrote:
>>>> * New error handling
>>>> * IRQ driven PIO (from Albert Lee)
>>>> * SATA NCQ support
>>>> * Hotplug support
>>>> * Port Multiplier support
>>>
>>> BTW, we often use PM to mean Power Management.
>>> Could we find a different acronym for Port Multiplier support,
>>> such as PMS or PX or PXS?
>>
>> Ok, maybe not PMS ?
>>
>> Can you imagine a bug report from someone that "has problem with PMS"?
>> :)
>>
> 
> Would be fun though.  :)
> 
> I thought about using another acronym for port multiplier too.  But the 
> spec uses that acronym all over the place, PM, PMP (Port Multiplier 
> Portnumber), which reminds me of USB full/high speed fiasco.
> 
> Urghh... I thought we could use power for power management inside libata 
> but that might be a bad idea.  So, PMS?

PMS is fine.  I encouraged the use of "UFO" for "UDP Fragmentation 
Offload" in network driver land, and it stuck.

This is Linux, we like to have fun around here :)

	Jeff

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Tejun Heo]

Jeff Garzik wrote:
> Tejun Heo wrote:
>> Stefan Smietanowski wrote:
>>> Randy.Dunlap wrote:
>>>>> * New error handling
>>>>> * IRQ driven PIO (from Albert Lee)
>>>>> * SATA NCQ support
>>>>> * Hotplug support
>>>>> * Port Multiplier support
>>>>
>>>> BTW, we often use PM to mean Power Management.
>>>> Could we find a different acronym for Port Multiplier support,
>>>> such as PMS or PX or PXS?
>>>
>>> Ok, maybe not PMS ?
>>>
>>> Can you imagine a bug report from someone that "has problem with PMS"?
>>> :)
>>>
>>
>> Would be fun though.  :)
>>
>> I thought about using another acronym for port multiplier too.  But 
>> the spec uses that acronym all over the place, PM, PMP (Port 
>> Multiplier Portnumber), which reminds me of USB full/high speed fiasco.
>>
>> Urghh... I thought we could use power for power management inside 
>> libata but that might be a bad idea.  So, PMS?
> 
> PMS is fine.  I encouraged the use of "UFO" for "UDP Fragmentation 
> Offload" in network driver land, and it stuck.
> 
> This is Linux, we like to have fun around here :)
> 

Currently, the candidates are...

px	: short (good), but I don't know, not pretty
pmul	: okay but a bit too long
pml	: pretty and official
pms	: pretty and fun

I think I'll go with either pms or pml.  Man, this decision is difficult.

-- 
tejun

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Jeff Garzik]

Tejun Heo wrote:
> Jeff Garzik wrote:
>> Tejun Heo wrote:
>>> Stefan Smietanowski wrote:
>>>> Randy.Dunlap wrote:
>>>>>> * New error handling
>>>>>> * IRQ driven PIO (from Albert Lee)
>>>>>> * SATA NCQ support
>>>>>> * Hotplug support
>>>>>> * Port Multiplier support
>>>>>
>>>>> BTW, we often use PM to mean Power Management.
>>>>> Could we find a different acronym for Port Multiplier support,
>>>>> such as PMS or PX or PXS?
>>>>
>>>> Ok, maybe not PMS ?
>>>>
>>>> Can you imagine a bug report from someone that "has problem with PMS"?
>>>> :)
>>>>
>>>
>>> Would be fun though.  :)
>>>
>>> I thought about using another acronym for port multiplier too.  But 
>>> the spec uses that acronym all over the place, PM, PMP (Port 
>>> Multiplier Portnumber), which reminds me of USB full/high speed fiasco.
>>>
>>> Urghh... I thought we could use power for power management inside 
>>> libata but that might be a bad idea.  So, PMS?
>>
>> PMS is fine.  I encouraged the use of "UFO" for "UDP Fragmentation 
>> Offload" in network driver land, and it stuck.
>>
>> This is Linux, we like to have fun around here :)
>>
> 
> Currently, the candidates are...
> 
> px    : short (good), but I don't know, not pretty
> pmul    : okay but a bit too long
> pml    : pretty and official
> pms    : pretty and fun
> 
> I think I'll go with either pms or pml.  Man, this decision is difficult.

To make it more difficult:  Honestly, I prefer Port MultiPlier (PMP), 
imitating (and perhaps overloading) the acronym used by the standard 
SATA FIS field.

:)

	Jeff

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Tejun Heo]

Jeff Garzik wrote:
> Tejun Heo wrote:
>> Jeff Garzik wrote:
>>> Tejun Heo wrote:
>>>> Stefan Smietanowski wrote:
>>>>> Randy.Dunlap wrote:
>>>>>>> * New error handling
>>>>>>> * IRQ driven PIO (from Albert Lee)
>>>>>>> * SATA NCQ support
>>>>>>> * Hotplug support
>>>>>>> * Port Multiplier support
>>>>>>
>>>>>> BTW, we often use PM to mean Power Management.
>>>>>> Could we find a different acronym for Port Multiplier support,
>>>>>> such as PMS or PX or PXS?
>>>>>
>>>>> Ok, maybe not PMS ?
>>>>>
>>>>> Can you imagine a bug report from someone that "has problem with PMS"?
>>>>> :)
>>>>>
>>>>
>>>> Would be fun though.  :)
>>>>
>>>> I thought about using another acronym for port multiplier too.  But 
>>>> the spec uses that acronym all over the place, PM, PMP (Port 
>>>> Multiplier Portnumber), which reminds me of USB full/high speed fiasco.
>>>>
>>>> Urghh... I thought we could use power for power management inside 
>>>> libata but that might be a bad idea.  So, PMS?
>>>
>>> PMS is fine.  I encouraged the use of "UFO" for "UDP Fragmentation 
>>> Offload" in network driver land, and it stuck.
>>>
>>> This is Linux, we like to have fun around here :)
>>>
>>
>> Currently, the candidates are...
>>
>> px    : short (good), but I don't know, not pretty
>> pmul    : okay but a bit too long
>> pml    : pretty and official
>> pms    : pretty and fun
>>
>> I think I'll go with either pms or pml.  Man, this decision is difficult.
> 
> To make it more difficult:  Honestly, I prefer Port MultiPlier (PMP), 
> imitating (and perhaps overloading) the acronym used by the standard 
> SATA FIS field.

Ah... I've excluded PMP because I thought it was already taken, but, 
yeah, it wouldn't cause noticeable confusion and fits the best.  I'll 
give PMP a try.

-- 
tejun

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Alan Cox]

On Gwe, 2006-05-12 at 21:22 +0200, Stefan Smietanowski wrote:
> Ok, maybe not PMS ?
> 
> Can you imagine a bug report from someone that "has problem with PMS"?
> :)

We've had a driver for the pms card for many years and nobody over the
age of about 18 has afaik found it amusing.

Alan

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Stefan Smietanowski]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

Alan Cox wrote:
> On Gwe, 2006-05-12 at 21:22 +0200, Stefan Smietanowski wrote:
> 
>>Ok, maybe not PMS ?
>>
>>Can you imagine a bug report from someone that "has problem with PMS"?
>>:)
> 
> We've had a driver for the pms card for many years and nobody over the
> age of about 18 has afaik found it amusing.

Depends, I never heard of the pms card but I do have this tingling
feeling that some actually will hear of and/or use port multipliers
for SATA meaning that "not many heard of the pms card so not many
over the age of 18 found it amusing" but not the same is true
for port multipliers.

// Stefan

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 253 bytes --]

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Michael Schierl]

On Fri, 12 May 2006 22:24:37 +0900, Tejun Heo wrote:

> ahci:		new EH, irq-pio, NCQ, hotplug

Should suspend-to-RAM work now on AHCI? It produces lots of messages now
but does not work either now.

# ls
ata1.00: exception Emask 0x10 SAct 0x1 SEra 0x4050000 action 0x3 frozen
ata1.00 tag 0 cmd 0x60 Emask 0x14 stat 0x40 err 0x0 (ATA bus error)
ata1: soft resetting port
ata1: softreset failed (1st FIS failed)
ata1: softreset failed, retrying in 5 secs
ata1: hard resettinq port
ata1: port is slow to respond, please be patient
ata1: port failed to respond (30 secs)
ata1: COMRESET failed (device not ready)
ata1: hardreset failed, retrying in 5 secs
ata1: hard resettinq port
ata1: port is slow to respond, please be patient
ata1: port failed to respond (30 secs)
ata1: COMRESET failed (device not ready)
ata1: reset failed, giving up
ata1.00: disabled
ata1: EH complete
sd 0:0:0:0: SCSI error: return code = 0x40000
...

It produces lots of more SCSI errors (I did not want to write all those
down...) but no ata1-errors any more.

Michael

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Jeff Garzik]

Michael Schierl wrote:

> On Fri, 12 May 2006 22:24:37 +0900, Tejun Heo wrote:
> 
>> ahci:		new EH, irq-pio, NCQ, hotplug
> 
> Should suspend-to-RAM work now on AHCI?

It probably still needs Hannes' AHCI patch, and possibly the SATA ACPI 
patches too.

	Jeff

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Michael Schierl]

Jeff Garzik schrieb:
> Michael Schierl wrote:
> 
>> On Fri, 12 May 2006 22:24:37 +0900, Tejun Heo wrote:
>>
>>> ahci:        new EH, irq-pio, NCQ, hotplug
>>
>> Should suspend-to-RAM work now on AHCI?
> 
> It probably still needs Hannes' AHCI patch, and possibly the SATA ACPI
> patches too.

hmm. ok. Hannes' patch was the one in http://lkml.org/lkml/2006/3/6/47 ?

I never found a kernel where I could apply that one and still compile
without errors :(

I am no C guru, so I had no success to fix this patch without even
knowing where to apply against... (and I don't know anything about
kernel programming or even ACHI low-level programming).

Is there a newer version available of that patch somewhere?

And - what SATA ACPI patches?

I have quite alot of patches related to sata and/or acpi (collected from
different mailing lists) here on hard disk but don't know which ones are
broken, outdated, etc. Most only apply on a 2.6.15 or 2.6.14-rc kernel...

If more recent patches are only available via git, I'd need some good
GIT tutorial first...

TIA, and sorry for stealing your time,

Michael

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[zhao, forrest]

On Tue, 2006-05-16 at 17:14 +0200, Michael Schierl wrote:
> hmm. ok. Hannes' patch was the one in http://lkml.org/lkml/2006/3/6/47 ?
> 
> I never found a kernel where I could apply that one and still compile
> without errors :(
> 
> I am no C guru, so I had no success to fix this patch without even
> knowing where to apply against... (and I don't know anything about
> kernel programming or even ACHI low-level programming).
> 
> Is there a newer version available of that patch somewhere?
> 
> And - what SATA ACPI patches?
> 
> I have quite alot of patches related to sata and/or acpi (collected from
> different mailing lists) here on hard disk but don't know which ones are
> broken, outdated, etc. Most only apply on a 2.6.15 or 2.6.14-rc kernel...
> 
> If more recent patches are only available via git, I'd need some good
> GIT tutorial first...
> 
> TIA, and sorry for stealing your time,
> 
> Michael
Michael,

I ported a patch from OpenSUSE for AHCI suspend/resume. You may find the
patch at:
http://marc.theaimsgroup.com/?l=linux-ide&m=114774543416039&w=2

Jeff,
If Michael have a successful AHCI suspend/resume with this patch, I'm
glad to port the patch to current libata-dev #upstream for the second
time to push it into stock kernel. How do you think?

Thanks,
Forrest

AHCI suspend works for me! (was: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel)

[Michael Schierl]

zhao, forrest schrieb:
>> And - what SATA ACPI patches?
>>
>> I have quite alot of patches related to sata and/or acpi (collected from
>> different mailing lists) here on hard disk but don't know which ones are
>> broken, outdated, etc. Most only apply on a 2.6.15 or 2.6.14-rc kernel...
>>
>> If more recent patches are only available via git, I'd need some good
>> GIT tutorial first...
>>
>> TIA, and sorry for stealing your time,
>>
>> Michael
> Michael,
> 
> I ported a patch from OpenSUSE for AHCI suspend/resume. You may find the
> patch at:
> y

I cannot see any patch in this mail...

However, the patch linked there "indirectly",

http://www.spinnaker.de/linux/c1320/sata-resume-2.6.16.5.patch

applies well on vanilla 2.6.16 (although not on top of the "new EH"
patch) and is the first one that really works (as far as I tested it).

I tested it on a minimal kernel (no network no sound no nothing); I'll
build a new "non-minimal" kernel now :) If I run into any problems; I'll
tell you.

Thank you.

Michael

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Jeff Garzik]

zhao, forrest wrote:
> On Tue, 2006-05-16 at 17:14 +0200, Michael Schierl wrote:
>> hmm. ok. Hannes' patch was the one in http://lkml.org/lkml/2006/3/6/47 ?
>>
>> I never found a kernel where I could apply that one and still compile
>> without errors :(
>>
>> I am no C guru, so I had no success to fix this patch without even
>> knowing where to apply against... (and I don't know anything about
>> kernel programming or even ACHI low-level programming).
>>
>> Is there a newer version available of that patch somewhere?
>>
>> And - what SATA ACPI patches?
>>
>> I have quite alot of patches related to sata and/or acpi (collected from
>> different mailing lists) here on hard disk but don't know which ones are
>> broken, outdated, etc. Most only apply on a 2.6.15 or 2.6.14-rc kernel...
>>
>> If more recent patches are only available via git, I'd need some good
>> GIT tutorial first...
>>
>> TIA, and sorry for stealing your time,
>>
>> Michael
> Michael,
> 
> I ported a patch from OpenSUSE for AHCI suspend/resume. You may find the
> patch at:
> http://marc.theaimsgroup.com/?l=linux-ide&m=114774543416039&w=2
> 
> Jeff,
> If Michael have a successful AHCI suspend/resume with this patch, I'm
> glad to port the patch to current libata-dev #upstream for the second
> time to push it into stock kernel. How do you think?

All reasonable patches accepted...

	Jeff

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Nicolas STRANSKY]

Le 05/12/2006 03:24 PM, Tejun Heo a écrit :
> Hello, all.
> 
> Lately libata has been going through a lot of changes and even more
> are around the corner.  I've been working on error handling and
> advanced SATA features for quite sometime now, and, finally, patches
> have been finalized and submitted for review a few days ago.
> 
> 2.6.18 is the target for mainline merge.  As there is quite some time
> between now and 2.6.18, I have made patches to update the current
> stable kernel to support the new features so that they can receive
> wider testing and interested people don't have to wait too long.  I
> intend to maintain these patches through 2.6.16 and 17 until the
> mainline merge happens.
> 
> Added new features are
> 
> * New error handling
> * IRQ driven PIO (from Albert Lee)
> * SATA NCQ support
> * Hotplug support
> * Port Multiplier support
> 
> The following drivers support new features.
> 
> ata_piix:	new EH, irq-pio, warmplug (hardware restriction)
> sata_sil:	new EH, irq-pio, hotplug
> ahci:		new EH, irq-pio, NCQ, hotplug
> sata_sil24:	new EH, irq-pio, NCQ, hotplug, Port Multiplier
> 
> More info can be found at the following URL.
> 
>  http://home-tj.org/wiki/index.php/Libata-tj-stable

Hi,

I've been using this patch for 2.6.16 for a month now, and it really
works very well. As 2.6.17 is now released, is there going to be a
"libata-tj" for this kernel as well ?
BTW, what is the status of sata_sil new code merge with mainline ? Is it
still expected to be in 2.6.18 ?

Thanks,
-- 
Nico
S'assure-t-on sur l'alliance
Qu'a faite la nécessité ?
	-+- Jean de La Fontaine (1621-1695),
	    Le Chat et le Rat (Fables VIII.22) -+-

Re: [ANNOUNCE] libata: new EH, NCQ, hotplug and PM patches against stable kernel

[Tejun Heo]

Nicolas STRANSKY wrote:
> Hi,
> 
> I've been using this patch for 2.6.16 for a month now, and it really
> works very well. As 2.6.17 is now released, is there going to be a
> "libata-tj" for this kernel as well ?

Yeap, just give me sometime.  I spent way too much time watching 
Stargate - Atlantis these few days but I'm getting back to work now.  :-P

> BTW, what is the status of sata_sil new code merge with mainline ? Is it
> still expected to be in 2.6.18 ?

Yes, things upto hotplug will be merged into 2.6.18.

-- 
tejun