From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 01/14] libata-hp-prep: add flags and eh_info/context fields for hotplug Date: Fri, 19 May 2006 11:28:29 -0400 Message-ID: <446DE41D.5000202@pobox.com> References: <11480445833575-git-send-email-htejun@gmail.com> <446DDD32.30702@pobox.com> <446DE189.8080307@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:22951 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S932348AbWESP3D (ORCPT ); Fri, 19 May 2006 11:29:03 -0400 In-Reply-To: <446DE189.8080307@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: mlord@pobox.com, albertcc@tw.ibm.com, alan@lxorguk.ukuu.org.uk, axboe@suse.de, forrest.zhao@intel.com, linux-ide@vger.kernel.org Tejun Heo wrote: > Jeff Garzik wrote: >> Tejun Heo wrote: >>> Add hotplug related flags and eh_info/context fields. >>> >>> Signed-off-by: Tejun Heo >>> >>> --- >>> >>> include/linux/libata.h | 19 ++++++++++++++++++- >>> 1 files changed, 18 insertions(+), 1 deletions(-) >>> >>> 95c2d43950709c541509bbedd692e984dc67b474 >>> diff --git a/include/linux/libata.h b/include/linux/libata.h >>> index 2803ab8..3fb6dc3 100644 >>> --- a/include/linux/libata.h >>> +++ b/include/linux/libata.h >>> @@ -131,6 +131,9 @@ enum { >>> >>> ATA_DFLAG_PIO = (1 << 8), /* device currently in PIO mode */ >>> >>> + ATA_DFLAG_DETACH = (1 << 16), >>> + ATA_DFLAG_DETACHED = (1 << 17), >>> + >>> ATA_DEV_UNKNOWN = 0, /* unknown device */ >>> ATA_DEV_ATA = 1, /* ATA device */ >>> ATA_DEV_ATA_UNSUP = 2, /* ATA device (unsupported) */ >>> @@ -153,6 +156,9 @@ enum { >>> ATA_FLAG_PIO_POLLING = (1 << 10), /* use polling PIO if LLD >>> * doesn't handle PIO interrupts */ >>> ATA_FLAG_NCQ = (1 << 11), /* host supports NCQ */ >>> + ATA_FLAG_HRST_TO_RESUME = (1 << 12), /* hardreset to resume >>> phy */ >>> + ATA_FLAG_CANT_WAIT_FIS34 = (1 << 13), /* can't wait for the >>> first D2H >>> + * Register FIS clearing BSY */ >> >> FIS34 is an awful name. I hereby ban it from libata :) >> >> Also those names are getting long. Consider shortening CANT_WAIT, >> perhaps to NOWAIT. And perhaps s/HRST_TO_RESUME/HRST_RESUMES/. >> >> ACK everything else in this patch. > > Yeah I hate FIS34 too. Can you suggest a name which can also signify > that the wait is for hotplug probing? ATA_FLAG_CANT_WAIT_HP? I wouldn't mention hotplug probing, because feels more like an implementation detail/requirement, rather than low-level ATA. Something that would be more clear to a libata newbie might be ATA_FLAG_SKIP_D2H_BSY. For general 'FIS34' substitutions, I would suggestion 'D2H' or 'D2HREG'. Jeff