From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: mlord@pobox.com, albertcc@tw.ibm.com, alan@lxorguk.ukuu.org.uk,
axboe@suse.de, forrest.zhao@intel.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 6/6] sata_sil24: kill ops->tf_read() and use ata_std_noop_check_status()
Date: Fri, 19 May 2006 11:48:12 -0400 [thread overview]
Message-ID: <446DE8BC.4060500@pobox.com> (raw)
In-Reply-To: <11480530901961-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> sil24 doesn't have single TF image. Result TF is bound to each
> command. As libata now allows TF-less implementation, kill
> ops->tf_read and use ata_std_noop_check_status() for check_status
> callbacks. Result TF is loaded directly from LRAM into qc->result_tf
> if necessary.
>
> This patch also makes sil24_hardreset() to request followup SRST as
> that's the only way to wait for !BSY. Note that the original
> implementation never worked - if the cached status was !BSY,
> ata_busy_sleep() finished immediately; otherwise, it timed out
> regardless of the actual device status.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
NAK, for reasons described in previous patchset.
next prev parent reply other threads:[~2006-05-19 15:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-19 15:38 [PATCHSET 02/03] prep LLDDs for hotplug support, take 2 Tejun Heo
2006-05-19 15:38 ` [PATCH 3/6] sata_sil: new interrupt handler Tejun Heo
2006-05-19 15:46 ` Jeff Garzik
2006-05-23 14:50 ` Tejun Heo
2006-05-23 22:04 ` Jeff Garzik
2006-05-23 22:07 ` Tejun Heo
2006-05-19 15:38 ` [PATCH 2/6] sata_sil: add new constants in preparation for " Tejun Heo
2006-05-19 15:38 ` [PATCH 1/6] libata: export ata_hsm_move() Tejun Heo
2006-05-19 15:38 ` [PATCH 5/6] sata_sil24: use sata_phy_debounce() in sil24_hardreset() Tejun Heo
2006-05-19 15:47 ` Jeff Garzik
2006-05-19 15:38 ` [PATCH 4/6] sata_sil24: rename PORT_PRB to PORT_LRAM and add PORT_LRAM_SLOT_SZ Tejun Heo
2006-05-19 15:38 ` [PATCH 6/6] sata_sil24: kill ops->tf_read() and use ata_std_noop_check_status() Tejun Heo
2006-05-19 15:48 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-05-11 15:14 [PATCHSET 07/11] prep LLDDs for hotplug support, take 1 (REPOST) Tejun Heo
2006-05-11 15:14 ` [PATCH 6/6] sata_sil24: kill ops->tf_read() and use ata_std_noop_check_status() Tejun Heo
2006-05-11 15:11 [PATCHSET 07/11] prep LLDDs for hotplug support, take 1 Tejun Heo
2006-05-11 15:11 ` [PATCH 6/6] sata_sil24: kill ops->tf_read() and use ata_std_noop_check_status() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446DE8BC.4060500@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=axboe@suse.de \
--cc=forrest.zhao@intel.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=mlord@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).