Re: [PATCH 3/6] sata_sil: new interrupt handler

[Tejun Heo <htejun@gmail.com>]

Jeff Garzik wrote:
>> +    /* ack bmdma irq events */
>> +    ap->ops->irq_clear(ap);
> 
> Don't use hook in LLDD

Okay.

>> +    spin_lock_irqsave(&host_set->lock, flags);
>> +
>> +    for (i = 0; i < host_set->n_ports; i++) {
>> +        struct ata_port *ap = host_set->ports[i];
>> +        u32 bmdma2 = readl(mmio_base + sil_port[ap->port_no].bmdma2);
>> +
>> +        if (unlikely(!ap || ap->flags & ATA_FLAG_DISABLED))
>> +            continue;
>> +
>> +        if (!(bmdma2 & SIL_DMA_COMPLETE))
>> +            continue;
>> +
>> +        sil_host_intr(ap, bmdma2);
>> +        handled = 1;
>> +    }
>> +
>> +    spin_unlock_irqrestore(&host_set->lock, flags);
> 
> NAK, unconditionally use spin_lock() and spin_unlock() on this hardware.

Can you explain more on this?  We almost never use those in libata and I 
don't see what's different for sata_sil.

-- 
tejun