From: Tejun Heo <htejun@gmail.com>
To: "Jérôme VUARAND" <jerome.vuarand@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: SiI3124 + SiI3726 pm
Date: Wed, 24 May 2006 22:07:04 -0700 [thread overview]
Message-ID: <44753B78.4090802@gmail.com> (raw)
In-Reply-To: <89d273ba0605242202l354ec106w22bccf649e5e1dfc@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
Jérôme VUARAND wrote:
> I just realised after the mail that the driver was really thinking
> there are 6 ports on the pm, since it's testing ata3.05 and ata4.05.
> These don't exist and generate errors. There's a bug somewhere and
> here is a workaround I made quickly to have correct enumeration
> behaviour (I hope no automatic process parse mails on this mailing
> list for patches, coz this one is not really clean) :
Can you try the attached patch?
--
tejun
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 561 bytes --]
diff --git a/drivers/scsi/libata-pm.c b/drivers/scsi/libata-pm.c
index 002d8b2..7a56ab7 100644
--- a/drivers/scsi/libata-pm.c
+++ b/drivers/scsi/libata-pm.c
@@ -327,6 +327,14 @@ static void ata_pm_quirks(u32 *gscr, int
*nr_ports -= 2;
*link_flags |= ATA_LFLAG_HRST_TO_RESUME;
}
+
+ /* Sil3726 reports one extra port and needs hardreset to
+ * resume PM link.
+ */
+ if (vendor == 0x1095 && devid == 0x3726) {
+ *nr_ports -= 1;
+ *link_flags |= ATA_LFLAG_HRST_TO_RESUME;
+ }
}
static int ata_pm_configure(struct ata_device *dev, int *r_nr_ports,
next parent reply other threads:[~2006-05-25 5:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <89d273ba0605242046x3d19dd06h74885048f229d519@mail.gmail.com>
[not found] ` <89d273ba0605242202l354ec106w22bccf649e5e1dfc@mail.gmail.com>
2006-05-25 5:07 ` Tejun Heo [this message]
2006-05-25 20:29 ` SiI3124 + SiI3726 pm saeed bishara
2006-05-25 20:54 ` Tejun Heo
2009-07-27 18:03 ` Jerome Vuarand
2009-07-28 2:38 ` Tejun Heo
2009-07-28 15:01 ` Jerome Vuarand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44753B78.4090802@gmail.com \
--to=htejun@gmail.com \
--cc=jerome.vuarand@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).