From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-ide@vger.kernel.org, torvalds@osdl.org, axboe@suse.de
Subject: Re: [PATCH alt2] libata resume fixes
Date: Sat, 27 May 2006 15:21:41 -0400 [thread overview]
Message-ID: <4478A6C5.2040201@rtr.ca> (raw)
In-Reply-To: <20060527191323.GA26671@havoc.gtf.org>
Jeff Garzik wrote:
...
> +
> +int pata_pci_device_resume(struct pci_dev *pdev)
> +{
> + struct device *dev = pci_dev_to_dev(pdev);
> + struct ata_host_set *host_set = dev_get_drvdata(dev);
> + struct ata_port *ap;
> + u8 status;
> + int i;
> +
> + ata_pci_device_resume(pdev);
> +
> + mdelay(400);
> +
> + for (i = 0; i < host_set->n_ports; i++) {
> + ap = host_set->ports[i];
> +
> + status = ata_busy_wait(ap, ATA_BUSY, 200000);
> + if (status & ATA_BUSY)
> + printk(KERN_ERR "ata%u: failed to resume\n", ap->id);
> + }
> +
> + return 0;
...
Okay, back again after two reboots. Same failure mode as all of the others.
System freezes for a 30-second timeout with no LCD-backlight on,
then comes up without functioning hard drive access. An immediate reboot
is necessary to do anything.
Linus's one-liner works perfectly, though.
Cheers
next prev parent reply other threads:[~2006-05-27 19:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-27 19:13 [PATCH alt2] libata resume fixes Jeff Garzik
2006-05-27 19:21 ` Mark Lord [this message]
2006-05-27 19:23 ` Jeff Garzik
2006-05-27 19:28 ` Mark Lord
2006-05-27 19:29 ` Jeff Garzik
2006-05-27 19:44 ` Mark Lord
2006-05-27 19:58 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4478A6C5.2040201@rtr.ca \
--to=liml@rtr.ca \
--cc=axboe@suse.de \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).