From: Jeff Garzik <jeff@garzik.org>
To: Mark Lord <liml@rtr.ca>
Cc: torvalds@osdl.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH alt4 v2] libata resume fixes
Date: Sat, 27 May 2006 16:56:41 -0400 [thread overview]
Message-ID: <4478BD09.5010309@garzik.org> (raw)
In-Reply-To: <4478B971.3060409@rtr.ca>
Mark Lord wrote:
> Jeff Garzik wrote:
>> Mark Lord wrote:
> ..
>> Yay! I'm familiar with the 0xD0 status on ata_piix, so this is really
>> good progress.
>>
>>
>>> Other than that, it's still dead -- disk I/O not working.
>>>
>>> Can this patch be combined with Linus's one-liner
>>> and still work on your machine?
>>
>> Does alt4v2 plus Linus's patch work on your machine? (I'm guessing "no")
>
> I haven't tried it here yet.
>
> One other thing: you patches keep adding a "pata" pci_device_resume
> handler.
>
> My disk is SATA, or at least libata thinks it is SATA.
> Just in case that makes any difference here.
>
> (it really is PATA, but seems to have a SATA bridge
> between it and the ICH6M SATA port).
That's just naming, which indicates it is a PATA-like BMDMA resume
handler. Don't worry about it.
As mentioned elsewhere, Linus's patch falls over when we start resuming
controllers with real SATA phy registers, so that would be a separate
sata_pci_device_resume() function.
Jeff
next prev parent reply other threads:[~2006-05-27 20:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-27 19:58 [PATCH alt4] libata resume fixes Jeff Garzik
2006-05-27 20:10 ` [PATCH alt4 v2] " Jeff Garzik
2006-05-27 20:14 ` Jeff Garzik
2006-05-27 20:30 ` Mark Lord
[not found] ` <4478B611.2030201@rtr.ca>
2006-05-27 20:32 ` Jeff Garzik
2006-05-27 20:41 ` Mark Lord
2006-05-27 20:56 ` Jeff Garzik [this message]
2006-05-27 21:00 ` Mark Lord
2006-05-27 21:06 ` Jeff Garzik
2006-05-27 21:09 ` Mark Lord
2006-05-27 21:14 ` Jeff Garzik
2006-05-27 20:13 ` [PATCH alt4] " Mark Lord
2006-05-27 20:52 ` [PATCH alt4 v3] " Jeff Garzik
2006-05-27 20:56 ` Mark Lord
2006-05-27 21:11 ` Jeff Garzik
2006-05-27 21:15 ` Mark Lord
2006-05-27 21:25 ` Jeff Garzik
2006-05-27 21:12 ` Mark Lord
2006-05-27 21:21 ` Jeff Garzik
2006-05-29 3:53 ` zhao, forrest
2006-05-29 5:25 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4478BD09.5010309@garzik.org \
--to=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).