From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH] Re: 2.6.17-rc5-git1: regression: resume from suspend(RAM) fails: libata issue Date: Sat, 27 May 2006 17:31:48 -0400 Message-ID: <4478C544.3090404@rtr.ca> References: <1148634262.2310.7.camel@forrest26.sh.intel.com> <200605271423.40037.liml@rtr.ca> <200605272245.30108.axboe@suse.de> <4478BD60.40806@garzik.org> <20060527211157.GA31275@suse.de> <4478C1DD.2030204@garzik.org> <20060527212011.GA31551@suse.de> <4478C39A.9060302@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([64.26.128.89]:27346 "EHLO mail.rtr.ca") by vger.kernel.org with ESMTP id S964959AbWE0Vbt (ORCPT ); Sat, 27 May 2006 17:31:49 -0400 In-Reply-To: <4478C39A.9060302@garzik.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: Jens Axboe , Linus Torvalds , "zhao, forrest" , Tejun Heo , linux-ide@vger.kernel.org Jeff Garzik wrote: .. > > Does it work if you move msleep() below pci_restore_state()? > " " " " below pci_enable_device()? > > I think the delay makes more sense after you wake up the controller... > > The fact that the above patch works most likely indicates the device, > not the controller, needs the delay. Another question here: I really would have expected the new EH code to eventually recover from this, by resetting the chip/drive/whatever. It doesn't. ??