From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH] Re: 2.6.17-rc5-git1: regression: resume from suspend(RAM) fails: libata issue Date: Sat, 27 May 2006 18:56:13 -0400 Message-ID: <4478D90D.4080901@rtr.ca> References: <200605272245.30108.axboe@suse.de> <4478BD60.40806@garzik.org> <20060527211157.GA31275@suse.de> <4478C1DD.2030204@garzik.org> <20060527212011.GA31551@suse.de> <4478CD4E.4000506@rtr.ca> <20060527221131.GA364@suse.de> <20060527223523.GD364@suse.de> <4478D82E.4030704@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([64.26.128.89]:30381 "EHLO mail.rtr.ca") by vger.kernel.org with ESMTP id S965006AbWE0W4P (ORCPT ); Sat, 27 May 2006 18:56:15 -0400 In-Reply-To: <4478D82E.4030704@garzik.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: Jens Axboe , Linus Torvalds , "zhao, forrest" , Tejun Heo , linux-ide@vger.kernel.org Jeff Garzik wrote: > Jens Axboe wrote: >> index b80d2e7..80fb1f9 100644 >> --- a/include/linux/libata.h >> +++ b/include/linux/libata.h >> @@ -742,7 +742,7 @@ static inline u8 ata_busy_wait(struct at >> >> static inline u8 ata_wait_idle(struct ata_port *ap) >> { >> - u8 status = ata_busy_wait(ap, ATA_BUSY | ATA_DRQ, 1000); >> + u8 status = ata_busy_wait(ap, ATA_BUSY | ATA_DRQ, 200000); > > > Ouch. That will slow down boot for a lot of otherwise-untouched users, Really? If a drive claims to be BUSY, then it shouldn't accept a new command. But yes, this may be a bit too mainline to risk at this point, given controller quirks and the like that may be spoofing the status. Cheers