From: Jeff Garzik <jgarzik@pobox.com>
To: Borislav Petkov <bbpetkov@yahoo.de>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata debugging: set initial dbg value
Date: Mon, 29 May 2006 01:10:11 -0400 [thread overview]
Message-ID: <447A8233.2090409@pobox.com> (raw)
In-Reply-To: <20060529045302.GA4680@zmei.tnic>
Borislav Petkov wrote:
> This patch sets the prerequisites for the new debugging scheme that more or
> less resembles Donald Becker's net driver example. This one liner doesn't
> change any functionality beside setting the appropriate debug level for the
> msg_enable control in the ata_port struct, which will be later used by the
> ata_msg_* macros to control the amount of debug information sent to printk.
>
> Signed-off-by: <petkov@uni-muenster.de>
>
>
> --- drivers/scsi/libata-core.c.orig 2006-05-28 10:09:48.000000000 +0200
> +++ drivers/scsi/libata-core.c 2006-05-28 10:10:19.000000000 +0200
Applied, though I had to apply it manually for two reasons:
1) Patch not properly rooted. Patch should be applyable with
patch -sp1 < patch
which means that you need another directory in front of the filename in
the diff, i.e.
--- linux/drivers/scsi/libata-core.c
+++ linux-new/drivers/scsi/libata-core.c
2) git-applymbox refused to apply the patch, with a "failed to apply"
reason. Possibly this was due to my hand-editing of the lines describe
in #1 above, but also its possible that you did not diff properly
against libata-dev.git#upstream. I don't know which.
prev parent reply other threads:[~2006-05-29 5:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-29 4:53 [PATCH] libata debugging: set initial dbg value Borislav Petkov
2006-05-29 5:10 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=447A8233.2090409@pobox.com \
--to=jgarzik@pobox.com \
--cc=bbpetkov@yahoo.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).