[PATCH] libata debugging: set initial dbg value

[PATCH] libata debugging: set initial dbg value

[Borislav Petkov]

This patch sets the prerequisites for the new debugging scheme that more or
less resembles Donald Becker's net driver example. This one liner doesn't
change any functionality beside setting the appropriate debug level for the
msg_enable control in the ata_port struct, which will be later used by the 
ata_msg_* macros to control the amount of debug information sent to printk.

Signed-off-by: <petkov@uni-muenster.de>


--- drivers/scsi/libata-core.c.orig	2006-05-28 10:09:48.000000000 +0200
+++ drivers/scsi/libata-core.c	2006-05-28 10:10:19.000000000 +0200
@@ -4456,6 +4456,7 @@ static void ata_host_init(struct ata_por
 	ap->cbl = ATA_CBL_NONE;
 	ap->active_tag = ATA_TAG_POISON;
 	ap->last_ctl = 0xFF;
+	ap->msg_enable = ATA_MSG_DRV;
 
 	INIT_WORK(&ap->port_task, NULL, NULL);
 	INIT_LIST_HEAD(&ap->eh_done_q);

	

	
		
___________________________________________________________ 
Telefonate ohne weitere Kosten vom PC zum PC: http://messenger.yahoo.de

Re: [PATCH] libata debugging: set initial dbg value

[Jeff Garzik]

Borislav Petkov wrote:
> This patch sets the prerequisites for the new debugging scheme that more or
> less resembles Donald Becker's net driver example. This one liner doesn't
> change any functionality beside setting the appropriate debug level for the
> msg_enable control in the ata_port struct, which will be later used by the 
> ata_msg_* macros to control the amount of debug information sent to printk.
> 
> Signed-off-by: <petkov@uni-muenster.de>
> 
> 
> --- drivers/scsi/libata-core.c.orig	2006-05-28 10:09:48.000000000 +0200
> +++ drivers/scsi/libata-core.c	2006-05-28 10:10:19.000000000 +0200

Applied, though I had to apply it manually for two reasons:

1) Patch not properly rooted.  Patch should be applyable with
	patch -sp1 < patch
which means that you need another directory in front of the filename in 
the diff, i.e.
	--- linux/drivers/scsi/libata-core.c
	+++ linux-new/drivers/scsi/libata-core.c

2) git-applymbox refused to apply the patch, with a "failed to apply" 
reason.  Possibly this was due to my hand-editing of the lines describe 
in #1 above, but also its possible that you did not diff properly 
against libata-dev.git#upstream.  I don't know which.