From: Tejun Heo <htejun@gmail.com>
To: "zhao, forrest" <forrest.zhao@intel.com>
Cc: jgarzik@pobox.com, mlord@pobox.com, albertcc@tw.ibm.com,
alan@lxorguk.ukuu.org.uk, axboe@suse.de,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 04/12] libata-hp-prep: update ata_scsi_find_dev() and friends
Date: Mon, 29 May 2006 18:09:51 +0900 [thread overview]
Message-ID: <447ABA5F.2070608@gmail.com> (raw)
In-Reply-To: <1148892037.3466.15.camel@forrest26.sh.intel.com>
>> +static struct ata_device * ata_find_dev(struct ata_port *ap, int id)
>> +{
>> + if (likely(id == 0 || (id == 1 && ap->flags & ATA_FLAG_SLAVE_POSS)))
>> + return &ap->device[id];
>> + return NULL;
>> +}
>> +
>
>>From my understanding, the definition of function ata_find_dev() should
> be in libata-core.c instead of libata-scsi.c. Does it make sense to you?
Could be. However, as it's currently used only inside libata-scsi.c, I
think we can leave it as static function for the time being.
--
tejun
next prev parent reply other threads:[~2006-05-29 9:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-29 6:25 [PATCHSET 01/03] prep for hotplug support, take 4 Tejun Heo
2006-05-29 6:25 ` [PATCH 01/12] libata-hp-prep: add flags and eh_info/context fields for hotplug Tejun Heo
2006-05-29 6:25 ` [PATCH 02/12] libata-hp-prep: implement ata_dev_init() Tejun Heo
2006-05-29 6:25 ` [PATCH 04/12] libata-hp-prep: update ata_scsi_find_dev() and friends Tejun Heo
2006-05-29 8:40 ` zhao, forrest
2006-05-29 9:09 ` Tejun Heo [this message]
2006-05-30 4:38 ` Jeff Garzik
2006-05-30 4:02 ` Jeff Garzik
2006-05-30 4:26 ` Tejun Heo
2006-05-30 4:37 ` Jeff Garzik
2006-05-30 4:43 ` Tejun Heo
2006-05-29 6:25 ` [PATCH 08/12] libata-hp-prep: add ata_scsi_wq Tejun Heo
2006-05-29 6:25 ` [PATCH 06/12] libata-hp-prep: implement ap->hw_sata_spd_limit Tejun Heo
2006-05-29 6:25 ` [PATCH 05/12] libata-hp-prep: use __ata_scsi_find_dev() Tejun Heo
2006-05-29 6:25 ` [PATCH 11/12] libata-hp-prep: add prereset() method and implement ata_std_prereset() Tejun Heo
2006-05-29 11:12 ` [PATCH 11/12] (updated) " Tejun Heo
2006-05-30 4:12 ` Jeff Garzik
2006-05-29 6:25 ` [PATCH 12/12] libata-hp-prep: implement followup softreset handling Tejun Heo
2006-05-30 4:12 ` Jeff Garzik
2006-05-29 6:25 ` [PATCH 09/12] libata-hp-prep: make probing related functions global Tejun Heo
2006-05-30 4:06 ` Jeff Garzik
2006-05-29 6:25 ` [PATCH 07/12] libata-hp-prep: store attached SCSI device Tejun Heo
2006-05-29 8:45 ` zhao, forrest
2006-05-29 9:14 ` Tejun Heo
2006-05-30 4:04 ` Jeff Garzik
2006-05-30 4:55 ` Tejun Heo
2006-05-29 6:25 ` [PATCH 10/12] libata-hp-prep: implement sata_phy_debounce() Tejun Heo
2006-05-30 4:10 ` Jeff Garzik
2006-05-30 5:08 ` Tejun Heo
2006-05-30 5:23 ` Jeff Garzik
2006-05-29 6:25 ` [PATCH 03/12] libata-hp-prep: make some ata_device fields persistent Tejun Heo
2006-05-30 4:00 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2006-05-31 11:05 [PATCHSET 01/03] prep for hotplug support, take 5 Tejun Heo
2006-05-31 11:05 ` [PATCH 04/12] libata-hp-prep: update ata_scsi_find_dev() and friends Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=447ABA5F.2070608@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=axboe@suse.de \
--cc=forrest.zhao@intel.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=mlord@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).