From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: mlord@pobox.com, albertcc@tw.ibm.com, alan@lxorguk.ukuu.org.uk,
axboe@suse.de, forrest.zhao@intel.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 07/13] libata-hp: implement unload-unplug
Date: Tue, 30 May 2006 13:37:07 +0900 [thread overview]
Message-ID: <447BCBF3.5090000@gmail.com> (raw)
In-Reply-To: <447BC8EB.3080607@pobox.com>
Jeff Garzik wrote:
> Tejun Heo wrote:
>> Implement unload unplug - driver unloading / PCI removal via hot
>> unplug path. This is done by ata_port_detach() which requests detach
>> of all devices, schedules EH and wait for it to complete. EH path is
>> slightly modified to handle this (e.g. force zero eh_info during
>> unloading). With this patch, EH and unloading are properly
>> synchronized and unloading should be safe under any circumstances.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> How does this behave for controller hotplug? For that case, there is
> nothing to EH...
I've only tested with module unloading but when EH is invoked for
unplugging, autopsy and report are skipped and recover is called with
zero ehi but with all DFLAG_DETACH set. This amounts to unconditional
detachment of all devices without any other operation (well, of course,
other than being synchronized to other EH invocations). So, I guess it
should work okay. Can you tell me how to test such condition? I guess
I can yank out my sil3132 and unload sata_sil24. Would that be enough?
--
tejun
next prev parent reply other threads:[~2006-05-30 4:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-29 6:38 [PATCHSET 03/03] add hotplug support, take 4 Tejun Heo
2006-05-29 6:38 ` [PATCH 02/13] libata-hp: implement hotplug Tejun Heo
2006-05-30 4:18 ` Jeff Garzik
2006-05-30 4:44 ` Tejun Heo
2006-05-29 6:38 ` [PATCH 03/13] libata-hp: implement SCSI part of hotplug Tejun Heo
2006-05-29 6:38 ` [PATCH 01/13] libata-hp: implement ata_eh_detach_dev() Tejun Heo
2006-05-30 4:17 ` Jeff Garzik
2006-05-29 6:38 ` [PATCH 06/13] libata-hp: implement bootplug Tejun Heo
2006-05-30 4:23 ` Jeff Garzik
2006-05-30 4:29 ` Tejun Heo
2006-05-30 4:34 ` Jeff Garzik
2006-05-30 4:40 ` Tejun Heo
2006-05-30 4:43 ` Jeff Garzik
2006-05-29 6:38 ` [PATCH 08/13] ata_piix: convert ata_piix to new probing mechanism Tejun Heo
2006-05-29 6:38 ` [PATCH 04/13] libata-hp: implement warmplug Tejun Heo
2006-05-29 6:38 ` [PATCH 05/13] libata-hp: hook warmplug Tejun Heo
2006-05-30 4:21 ` Jeff Garzik
2006-05-29 6:38 ` [PATCH 10/13] ahci: convert to new probing mechanism and add hotplug support Tejun Heo
2006-05-30 4:27 ` Jeff Garzik
2006-05-29 6:38 ` [PATCH 09/13] sata_sil: " Tejun Heo
2006-05-30 4:26 ` Jeff Garzik
2006-05-29 6:38 ` [PATCH 12/13] libata-hp: killl ops->probe_reset Tejun Heo
2006-05-29 6:38 ` [PATCH 13/13] libata-hp: move ata_do_reset() to libata-eh.c Tejun Heo
2006-05-30 4:28 ` Jeff Garzik
2006-05-29 6:38 ` [PATCH 11/13] sata_sil24: convert to new probing mechanism and add hotplug support Tejun Heo
2006-05-30 4:28 ` Jeff Garzik
2006-05-29 6:38 ` [PATCH 07/13] libata-hp: implement unload-unplug Tejun Heo
2006-05-30 4:24 ` Jeff Garzik
2006-05-30 4:37 ` Tejun Heo [this message]
2006-05-30 4:44 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2006-05-19 15:48 [PATCHSET 03/03] add hotplug support, take 3 Tejun Heo
2006-05-19 15:48 ` [PATCH 07/13] libata-hp: implement unload-unplug Tejun Heo
2006-05-19 16:10 ` Jeff Garzik
2006-05-23 14:53 ` Tejun Heo
2006-05-11 15:32 [PATCHSET 08/11] add hotplug support, take 2 Tejun Heo
2006-05-11 15:32 ` [PATCH 07/13] libata-hp: implement unload-unplug Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=447BCBF3.5090000@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=axboe@suse.de \
--cc=forrest.zhao@intel.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=mlord@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).