From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command Date: Tue, 30 May 2006 00:41:32 -0400 Message-ID: <447BCCFC.10908@garzik.org> References: <1148547763.23979.15.camel@forrest26.sh.intel.com> <44779A05.4010209@garzik.org> <447AB9FB.6020706@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:35557 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S932125AbWE3Elg (ORCPT ); Tue, 30 May 2006 00:41:36 -0400 In-Reply-To: <447AB9FB.6020706@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: "zhao, forrest" , liml@rtr.ca, linux-ide@vger.kernel.org Tejun Heo wrote: > * I've renamed ata_hotplug_wq to ata_scsi_wq in hotplug patches. I > think rescan can use this wq instead of creating its own. I think we will use this workqueue even when SCSI is optional, so ata_scsi_wq may not be the best name, long term. I ACK'd its inclusion of course, so not a big deal. > * When snooping for SETFEATURES in ata_scsi_qc_complete(), why check > cdb[0] for ATA_16/12? Isn't simply checking tf.command enough? yes > * There's a race window between ATA revalidation and SCSI rescan. We > can plug this hole by deferring commands till rescan is complete. But I > doubt it would be worth the trouble. probably, we'll see... :) Jeff