Re: [PATCH] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command

[Tejun Heo <htejun@gmail.com>]

Jeff Garzik wrote:
> Tejun Heo wrote:
>> * I've renamed ata_hotplug_wq to ata_scsi_wq in hotplug patches.  I 
>> think rescan can use this wq instead of creating its own.
> 
> I think we will use this workqueue even when SCSI is optional, so 
> ata_scsi_wq may not be the best name, long term.  I ACK'd its inclusion 
> of course, so not a big deal.

As it seems there will be another round of hotplug patches, I can rename 
it without too much trouble.  My candidates are...

ata_aux_wq
ata_management_wq / ata_mgmt_wq
ata_errands_wq

>> * When snooping for SETFEATURES in ata_scsi_qc_complete(), why check 
>> cdb[0] for ATA_16/12?  Isn't simply checking tf.command enough?
> 
> yes
> 
> 
>> * There's a race window between ATA revalidation and SCSI rescan.  We 
>> can plug this hole by deferring commands till rescan is complete.  But 
>> I doubt it would be worth the trouble.
> 
> probably, we'll see...  :)

Yeap, let's see.  I think this should fix Ric's cache type / barrier 
type problem.

-- 
tejun