From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: "zhao, forrest" <forrest.zhao@intel.com>,
liml@rtr.ca, linux-ide@vger.kernel.org
Subject: Re: [PATCH] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command
Date: Tue, 30 May 2006 14:10:56 +0900 [thread overview]
Message-ID: <447BD3E0.4010002@gmail.com> (raw)
In-Reply-To: <447BD0AE.2080904@garzik.org>
Jeff Garzik wrote:
> Tejun Heo wrote:
>> Jeff Garzik wrote:
>>> Tejun Heo wrote:
>>>> * I've renamed ata_hotplug_wq to ata_scsi_wq in hotplug patches. I
>>>> think rescan can use this wq instead of creating its own.
>>>
>>> I think we will use this workqueue even when SCSI is optional, so
>>> ata_scsi_wq may not be the best name, long term. I ACK'd its
>>> inclusion of course, so not a big deal.
>>
>> As it seems there will be another round of hotplug patches, I can
>> rename it without too much trouble. My candidates are...
>>
>> ata_aux_wq
>> ata_management_wq / ata_mgmt_wq
>> ata_errands_wq
>
> Another thing to consider is using the kthread API, ignore workqueues,
> and simply creating "one-shot" threads as needed.
It wouldn't work for SCSI hotplug. It depends on that there is only one
thread running the thing, so I think wq is the better choice. Any
suggestion on naming?
--
tejun
next prev parent reply other threads:[~2006-05-30 5:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-25 9:02 [PATCH] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command zhao, forrest
2006-05-27 0:15 ` Jeff Garzik
2006-05-29 6:35 ` zhao, forrest
2006-05-29 11:29 ` Mark Lord
2006-05-29 9:08 ` Tejun Heo
2006-05-29 9:18 ` zhao, forrest
2006-05-29 9:46 ` Tejun Heo
2006-05-29 9:20 ` Jeff Garzik
2006-05-29 9:43 ` Tejun Heo
2006-05-30 3:57 ` Jeff Garzik
2006-05-30 4:41 ` Jeff Garzik
2006-05-30 4:50 ` Tejun Heo
2006-05-30 4:57 ` Jeff Garzik
2006-05-30 5:10 ` Tejun Heo [this message]
2006-05-30 5:08 ` zhao, forrest
2006-05-30 7:22 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=447BD3E0.4010002@gmail.com \
--to=htejun@gmail.com \
--cc=forrest.zhao@intel.com \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).