From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command Date: Tue, 30 May 2006 14:10:56 +0900 Message-ID: <447BD3E0.4010002@gmail.com> References: <1148547763.23979.15.camel@forrest26.sh.intel.com> <44779A05.4010209@garzik.org> <447AB9FB.6020706@gmail.com> <447BCCFC.10908@garzik.org> <447BCF0A.7020709@gmail.com> <447BD0AE.2080904@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from wr-out-0506.google.com ([64.233.184.239]:8181 "EHLO wr-out-0506.google.com") by vger.kernel.org with ESMTP id S932069AbWE3FLD (ORCPT ); Tue, 30 May 2006 01:11:03 -0400 Received: by wr-out-0506.google.com with SMTP id i7so1026982wra for ; Mon, 29 May 2006 22:11:02 -0700 (PDT) In-Reply-To: <447BD0AE.2080904@garzik.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: "zhao, forrest" , liml@rtr.ca, linux-ide@vger.kernel.org Jeff Garzik wrote: > Tejun Heo wrote: >> Jeff Garzik wrote: >>> Tejun Heo wrote: >>>> * I've renamed ata_hotplug_wq to ata_scsi_wq in hotplug patches. I >>>> think rescan can use this wq instead of creating its own. >>> >>> I think we will use this workqueue even when SCSI is optional, so >>> ata_scsi_wq may not be the best name, long term. I ACK'd its >>> inclusion of course, so not a big deal. >> >> As it seems there will be another round of hotplug patches, I can >> rename it without too much trouble. My candidates are... >> >> ata_aux_wq >> ata_management_wq / ata_mgmt_wq >> ata_errands_wq > > Another thing to consider is using the kthread API, ignore workqueues, > and simply creating "one-shot" threads as needed. It wouldn't work for SCSI hotplug. It depends on that there is only one thread running the thing, so I think wq is the better choice. Any suggestion on naming? -- tejun