Re: [PATCH] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command

[Tejun Heo <htejun@gmail.com>]

zhao, forrest wrote:
> On Tue, 2006-05-30 at 14:10 +0900, Tejun Heo wrote:
>> Jeff Garzik wrote:
>>> Tejun Heo wrote:
>>>> Jeff Garzik wrote:
>>>>> Tejun Heo wrote:
>>>>>> * I've renamed ata_hotplug_wq to ata_scsi_wq in hotplug patches.  I 
>>>>>> think rescan can use this wq instead of creating its own.
>>>>> I think we will use this workqueue even when SCSI is optional, so 
>>>>> ata_scsi_wq may not be the best name, long term.  I ACK'd its 
>>>>> inclusion of course, so not a big deal.
>>>> As it seems there will be another round of hotplug patches, I can 
>>>> rename it without too much trouble.  My candidates are...
>>>>
>>>> ata_aux_wq
>>>> ata_management_wq / ata_mgmt_wq
>>>> ata_errands_wq
>>> Another thing to consider is using the kthread API, ignore workqueues, 
>>> and simply creating "one-shot" threads as needed.
>> It wouldn't work for SCSI hotplug.  It depends on that there is only one 
>> thread running the thing, so I think wq is the better choice.  Any 
>> suggestion on naming?
> 
> ata_misc_wq?
> ata_sweep_wq?

I think I'm going with ata_aux_wq.

-- 
tejun