From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [git patch] libata resume fix Date: Tue, 30 May 2006 09:22:32 -0400 Message-ID: <447C4718.6090802@rtr.ca> References: <20060528203419.GA15087@havoc.gtf.org> <1148938482.5959.27.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([64.26.128.89]:45233 "EHLO mail.rtr.ca") by vger.kernel.org with ESMTP id S1751400AbWE3NWe (ORCPT ); Tue, 30 May 2006 09:22:34 -0400 In-Reply-To: <1148938482.5959.27.camel@localhost.localdomain> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Benjamin Herrenschmidt Cc: Jeff Garzik , Andrew Morton , Linus Torvalds , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Benjamin Herrenschmidt wrote: > On Sun, 2006-05-28 at 16:34 -0400, Jeff Garzik wrote: >> Please pull from 'upstream-fixes' branch of >> master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git >> >> to receive the following updates: >> >> drivers/scsi/libata-core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> Mark Lord: >> the latest consensus libata resume fix > > If your devices are coming from poweron-reset then you will have to wait > up to 31 seconds :( And yes, I _did_ have such a device at one point. Not in a suspend/resume capable notebook, though. I don't know of *any* notebook drives that take longer than perhaps five seconds to spin-up and accept commands. Such a slow drive wouldn't really be tolerated by end-users, which is why they don't exist. But I suppose people will want to suspend/resume bigger machines too, in which case a 10000rpm Raptor might need 15 seconds or so. We could bump up the existing timeout, I suppose. Perhaps Jeff could comment on any potential harm in libata for going all the way to 3100000 with the timeout? Cheers