From: Tejun Heo <htejun@gmail.com>
To: Christoph Hellwig <hch@infradead.org>, Jens Axboe <axboe@suse.de>,
James Bottomley <James.Bottomley@SteelEye.com>,
Dave Miller <davem@redhat.com>,
bzolnier@gmail.com, james.steward@dynamicratings.com,
jgarzik@pobox.com, mattjreimer@gmail.com,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
rmk@arm.linux.org.uk, lkml <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/5] SCSI: add cpu cache flushes after kmapping and modifying a page
Date: Sun, 04 Jun 2006 18:13:26 +0900 [thread overview]
Message-ID: <4482A436.8000703@gmail.com> (raw)
In-Reply-To: <20060604082035.GB29696@infradead.org>
Christoph Hellwig wrote:
> On Sun, Jun 04, 2006 at 12:41:20PM +0900, Tejun Heo wrote:
>> local_irq_save(flags);
>> buf = kmap_atomic(sg->page, KM_IRQ0) + sg->offset;
>> memcpy(buf, tw_dev->generic_buffer_virt[request_id], sg->length);
>> + flush_kernel_dcache_page(kmap_atomic_to_page(buf - sg->offset));
>> kunmap_atomic(buf - sg->offset, KM_IRQ0);
>> local_irq_restore(flags);
>
> all these should switch to scsi_kmap_atomic_sg which should do the
> flush_kernel_dcache_page call for you.
>
This is not specific to scsi or block. This is a common problem for all
kmap users. As I wrote in the other mail, I think this should be
mandated at the kmap/kunmap() interface.
--
tejun
next prev parent reply other threads:[~2006-06-04 9:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-04 3:41 [PATCHSET] block: fix PIO cache coherency bug, take 2 Tejun Heo
2006-06-04 3:41 ` [PATCH 1/5] arm: implement flush_kernel_dcache_page() Tejun Heo
2006-06-04 3:49 ` [PATCH 1/5] (REPOST) " Tejun Heo
2006-06-04 6:45 ` [PATCH 1/5] " David Miller
2006-06-04 6:53 ` Tejun Heo
2006-06-04 7:04 ` David Miller
2006-06-04 3:41 ` [PATCH 3/5] libata: add cpu cache flushes after kmapping and modifying a page Tejun Heo
2006-06-04 3:41 ` [PATCH 2/5] ide: " Tejun Heo
2006-06-04 8:17 ` Christoph Hellwig
2006-06-04 9:09 ` Tejun Heo
2006-06-04 3:41 ` [PATCH 4/5] SCSI: " Tejun Heo
2006-06-04 8:20 ` Christoph Hellwig
2006-06-04 9:13 ` Tejun Heo [this message]
2006-06-04 20:24 ` Guennadi Liakhovetski
2006-06-04 3:41 ` [PATCH 5/5] md: " Tejun Heo
2006-06-04 20:44 ` [PATCHSET] block: fix PIO cache coherency bug, take 2 Russell King
2006-06-04 22:23 ` Russell King
2006-06-05 14:27 ` James Bottomley
2006-06-05 14:44 ` Russell King
2006-06-05 15:24 ` James Bottomley
2006-06-05 15:34 ` Russell King
2006-06-05 15:47 ` James Bottomley
2006-06-05 15:48 ` Russell King
2006-06-05 16:16 ` James Bottomley
2006-06-05 16:37 ` Russell King
2006-06-05 13:43 ` James Bottomley
2006-06-06 11:00 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4482A436.8000703@gmail.com \
--to=htejun@gmail.com \
--cc=James.Bottomley@SteelEye.com \
--cc=axboe@suse.de \
--cc=bzolnier@gmail.com \
--cc=davem@redhat.com \
--cc=g.liakhovetski@gmx.de \
--cc=hch@infradead.org \
--cc=james.steward@dynamicratings.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mattjreimer@gmail.com \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).