From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [git-patch] hotplug fix patches added
Date: Sun, 11 Jun 2006 09:35:26 -0400 [thread overview]
Message-ID: <448C1C1E.7080109@pobox.com> (raw)
In-Reply-To: <448B7FFD.9050507@gmail.com>
Tejun Heo wrote:
> Hello,
>
> Two hotplug fix patches have been added to libata-tj #for-jeff.
>
> * libata: add missing finish_wait() call in ata_port_wait_eh()
> * libata: cosmetic change in struct ata_port
>
> The following two patches have been dropped as it hasn't been acked yet.
>
> * ata_piix: fix ghost device probing by honoring PCS present bits[1]
Seems vaguely OK to me...
> * libata: add ata_port->private_flags[2]
What's the justification for this? Running out of room in flags?
If we are going to do this, I would move any such flags to the
LLDD-allocated hpriv structure completely. I wouldn't add hpriv_flags
to struct ata_port.
Jeff
next prev parent reply other threads:[~2006-06-11 13:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-11 2:29 [git-patch] hotplug fix patches added Tejun Heo
2006-06-11 13:35 ` Jeff Garzik [this message]
2006-06-11 13:50 ` Tejun Heo
2006-06-12 13:41 ` Jeff Garzik
2006-06-12 13:46 ` Tejun Heo
2006-06-11 13:51 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=448C1C1E.7080109@pobox.com \
--to=jgarzik@pobox.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).