From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 4/6] libata: Add ata_host_flags Date: Sun, 11 Jun 2006 23:26:43 -0400 Message-ID: <448CDEF3.1000703@pobox.com> References: <200606071625.k57GPrit014721@d01av01.pok.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:32640 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1750730AbWFLD0p (ORCPT ); Sun, 11 Jun 2006 23:26:45 -0400 In-Reply-To: <200606071625.k57GPrit014721@d01av01.pok.ibm.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Brian King Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, Alan Cox Brian King wrote: > Since SATA devices attached to SAS HBAs will not have > a host_set, add a helper function to retrieve the host_set > flags which can check for the existence of a host_set. > > Signed-off-by: Brian King > --- > > libata-dev-bjking1/drivers/scsi/libata-core.c | 7 +++---- > libata-dev-bjking1/include/linux/libata.h | 7 +++++++ > 2 files changed, 10 insertions(+), 4 deletions(-) > > diff -puN drivers/scsi/libata-core.c~libata_sas_no_simplex drivers/scsi/libata-core.c > --- libata-dev/drivers/scsi/libata-core.c~libata_sas_no_simplex 2006-06-06 08:55:43.000000000 -0500 > +++ libata-dev-bjking1/drivers/scsi/libata-core.c 2006-06-06 08:55:43.000000000 -0500 > @@ -2161,7 +2161,7 @@ int ata_set_mode(struct ata_port *ap, st > /* Record simplex status. If we selected DMA then the other > * host channels are not permitted to do so. > */ > - if (used_dma && (ap->host_set->flags & ATA_HOST_SIMPLEX)) > + if (used_dma && (ata_host_flags(ap) & ATA_HOST_SIMPLEX)) I'm not sure I like this one. Will have to think a bit more on this -- there might be a need for ipr to carry some cross-port libata state. Jeff