From: Jeff Garzik <jgarzik@pobox.com>
To: Borislav Petkov <bbpetkov@yahoo.de>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/n] libata-core.c conversion to new debugging scheme, part 1 (25% done)
Date: Sun, 11 Jun 2006 23:48:37 -0400 [thread overview]
Message-ID: <448CE415.6070901@pobox.com> (raw)
In-Reply-To: <20060531054633.GA4875@zmei.tnic>
Borislav Petkov wrote:
> This patch converts the first 25% of libata-core.c to the new debugging scheme.
>
> Signed-off-by: <petkov@uni-muenster.de>
After I hand-applied a lot of this, and looked at the result, I would
request further updates:
1) The message level order is a bit off. Following the original
Becker-designed strategy (netif.txt), the ATA_MSG_xxx bits should be
ordered in order of verbosity, where that order is passed to
ata_msg_init() from the user.
This implies that that ATA_MSG_ERR (the most important) should be 0x1,
_WARN should be 0x2, PROBE(?), DRV(?), and so on.
2) rediff and resend this "part 1" patch against the latest
libata-dev.git#upstream, which looked mostly OK
Jeff
prev parent reply other threads:[~2006-06-12 3:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-31 5:46 [PATCH 1/n] libata-core.c conversion to new debugging scheme, part 1 (25% done) Borislav Petkov
2006-05-31 6:39 ` Jeff Garzik
2006-06-01 5:38 ` Borislav Petkov
2006-06-01 6:09 ` Tejun Heo
2006-06-01 6:14 ` Jeff Garzik
2006-06-02 7:32 ` Borislav Petkov
2006-06-01 6:44 ` Borislav Petkov
2006-06-12 3:11 ` Jeff Garzik
2006-06-12 3:48 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=448CE415.6070901@pobox.com \
--to=jgarzik@pobox.com \
--cc=bbpetkov@yahoo.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).