From: Jeff Garzik <jgarzik@pobox.com>
To: "zhao, forrest" <forrest.zhao@intel.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH v5] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command
Date: Sun, 11 Jun 2006 23:53:23 -0400 [thread overview]
Message-ID: <448CE533.1090607@pobox.com> (raw)
In-Reply-To: <1150081562.5721.26.camel@forrest26.sh.intel.com>
zhao, forrest wrote:
> OK. I ported it to latest #upstream
>
> Signed-off-by: Zhao, Forrest <forrest.zhao@intel.com>
Patch content looks OK, but
1) "OK. I ported it to latest #upstream" is not a good description :) I
use the git-applymbox script to apply the patch, and the full technical
patch description is copied from your email's message body directly into
the Linux kernel changelog.
The appropriate place for comments like "OK. I ported it to latest
#upstream" is following the "---" description terminator line. See
Tejun's patches for an example :)
2) Both git-applymbox(1) and patch(1) fail to apply the patch:
[jgarzik@pretzel libata-dev]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt
1 patch(es) to process.
Applying 'Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command'
fatal: corrupt patch at line 84
[jgarzik@pretzel libata-dev]$ patch -sp1 < /g/tmp/mbox
patch: **** malformed patch at line 144: *args,
prev parent reply other threads:[~2006-06-12 3:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-12 3:06 [PATCH v5] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command zhao, forrest
2006-06-12 3:50 ` Tejun Heo
2006-06-12 3:53 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=448CE533.1090607@pobox.com \
--to=jgarzik@pobox.com \
--cc=forrest.zhao@intel.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).