* [PATCH] libata: fix ATA_EH_REVALIDATE clearing
@ 2006-06-12 5:11 Tejun Heo
2006-06-12 6:11 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2006-06-12 5:11 UTC (permalink / raw)
To: Jeff Garzik, linux-ide
ATA_EH_REVALIDATE should be cleared after all devices on the target
port have been revalidated. Fix ata_eh_revalidate_and_attach()
accordingly.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/scsi/libata-eh.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
1e3e586afea4afc1ef58fe8b21388017e9a4da57
diff --git a/drivers/scsi/libata-eh.c b/drivers/scsi/libata-eh.c
index f82799e..782dfba 100644
--- a/drivers/scsi/libata-eh.c
+++ b/drivers/scsi/libata-eh.c
@@ -1556,8 +1556,6 @@ static int ata_eh_revalidate_and_attach(
/* schedule the scsi_rescan_device() here */
queue_work(ata_aux_wq, &(ap->scsi_rescan_task));
-
- ehc->i.action &= ~ATA_EH_REVALIDATE;
} else if (dev->class == ATA_DEV_UNKNOWN &&
ehc->tries[dev->devno] &&
ata_class_enabled(ehc->classes[dev->devno])) {
@@ -1578,7 +1576,9 @@ static int ata_eh_revalidate_and_attach(
}
}
- if (rc)
+ if (rc == 0)
+ ehc->i.action &= ~ATA_EH_REVALIDATE;
+ else
*r_failed_dev = dev;
DPRINTK("EXIT\n");
--
1.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libata: fix ATA_EH_REVALIDATE clearing
2006-06-12 5:11 [PATCH] libata: fix ATA_EH_REVALIDATE clearing Tejun Heo
@ 2006-06-12 6:11 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-06-12 6:11 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-12 6:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-12 5:11 [PATCH] libata: fix ATA_EH_REVALIDATE clearing Tejun Heo
2006-06-12 6:11 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).