From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [git-patch] hotplug fix patches added
Date: Mon, 12 Jun 2006 22:46:21 +0900 [thread overview]
Message-ID: <448D702D.5010507@gmail.com> (raw)
In-Reply-To: <448D6F09.3080609@pobox.com>
Jeff Garzik wrote:
>> Several drivers only need flags. IMHO, having to allocate hpriv just
>> for flags is a bit annoying. I also thought about separating
>> capability flags and dynamic flags but couldn't think of proper field
>> name. ap->dyn_flags? Also, it would be easy to screw up and test the
>> wrong field. Another sucky option was using u64 for flags.
>
> I tend to think that most drivers fall into two categories:
>
> * bmdma (PCI IDE-like) drivers
> * drivers which already do their own hpriv allocation and management
>
> Therefore, I would be OK with adding a bmdma_flags member, to be used
> only by bmdma drivers [and eventually separated from the high level
> libata API, as discussed]. Otherwise, I would go ahead and add code to
> allocate an hpriv structure in the driver.
Okay, bmdma_flags then. I'll reserve lower 16 bits for generic bmdma
flags and allow LLDDs to use upper 16 bits.
--
tejun
next prev parent reply other threads:[~2006-06-12 13:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-11 2:29 [git-patch] hotplug fix patches added Tejun Heo
2006-06-11 13:35 ` Jeff Garzik
2006-06-11 13:50 ` Tejun Heo
2006-06-12 13:41 ` Jeff Garzik
2006-06-12 13:46 ` Tejun Heo [this message]
2006-06-11 13:51 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=448D702D.5010507@gmail.com \
--to=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).