From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] libata: kill ATA_FLAG_SRST
Date: Mon, 12 Jun 2006 10:59:30 -0400 [thread overview]
Message-ID: <448D8152.1080902@pobox.com> (raw)
In-Reply-To: <20060612144100.GB3892@htj.dyndns.org>
Tejun Heo wrote:
> As EDD support is removed, a LLD must implement either SRST or SATA
> reset. ATA_FLAG_SATA_RESET is enough to represent which one a LLD
> implements. Kill ATA_FLAG_SRST.
>
> Note that both flags are already marked obsolete. ATA_FLAG_SATA_RESET
> will be removed too once all LLDs are converted to new probing
> mechanism. This partial removal is to make room for a new flag needed
> for new PM.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
NAK. This will break too many drivers right now (e.g. even more in the
#pata-drivers branch).
My suggestion would be to create a patch that converts as many LLDDs as
you can to the new probing/EH. Ripping through the bmdma+PHY style
controllers should be easy, for example.
Additionally, I would appreciate it if you would patch the #pata-drivers
branch (in a separate patch), if you make a change across all libata
LLDDs. Otherwise the pata-drivers branch will _rapidly_ fall behind,
which is something that I don't want to happen.
Finally, please update Documentation/DocBook/libata.tmpl, at least for
the ata_port_operations changes made by you. I can work on updating the
EH and other sections myself, if you still dislike DocBook :) But I
really want the libata driver API reference to stay current. (Alan
grumbled at me about this, which I agree)
Jeff
next prev parent reply other threads:[~2006-06-12 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-12 14:41 [PATCH 1/2] libata: kill ATA_FLAG_SRST Tejun Heo
2006-06-12 14:44 ` [PATCH 2/2] libata: shift ATA_FLAG_* bits to make room for a new flag Tejun Heo
2006-06-12 14:59 ` Jeff Garzik [this message]
2006-06-12 15:09 ` [PATCH 1/2] libata: kill ATA_FLAG_SRST Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=448D8152.1080902@pobox.com \
--to=jgarzik@pobox.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).