From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: convert several bmdma-style controllers to new EH, take #2
Date: Thu, 15 Jun 2006 00:44:49 +0900 [thread overview]
Message-ID: <44902EF1.7030503@gmail.com> (raw)
In-Reply-To: <448F5BD2.6060905@pobox.com>
Jeff Garzik wrote:
> Tejun Heo wrote:
>> Convert sata_sis, svw, uli and vsc drivers to new EH. All the drivers
>> used to specify ATA_FLAG_SATA_RESET to tell libata to use SATA
>> hardreset instead of SRST.
>>
>> This patch preserves the behavior by defining private error handler
>> for each driver which only supports SATA hardreset. It is likely that
>> all these controllers support SRST and can simply use the stock bmdma
>> EH. The private EH methods will be removed after each driver is
>> tested w/ the stock bmdma EH.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> Too cautious :) I don't want to add the duplicate code, and then just
> remove it later when things are they are supposed to work.
>
> Just make sure your changes will either (a) work or (b) fail in an
> obvious way :)
>
> Then call for testers...
Cool, I like that. For get this and the via patch. Will post braver
version tomorrow. :)
--
tejun
next prev parent reply other threads:[~2006-06-14 15:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-13 11:51 [PATCH] libata: convert several bmdma-style controllers to new EH Tejun Heo
2006-06-13 19:28 ` Tejun Heo
2006-06-13 21:43 ` [PATCH] libata: convert several bmdma-style controllers to new EH, take #2 Tejun Heo
2006-06-14 0:44 ` Jeff Garzik
2006-06-14 15:44 ` Tejun Heo [this message]
2006-06-16 6:00 ` [PATCH] libata: convert several bmdma-style controllers to new EH, take #3 Tejun Heo
2006-06-20 9:13 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44902EF1.7030503@gmail.com \
--to=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).