From: Albert Lee <albertcc@tw.ibm.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Linux IDE <linux-ide@vger.kernel.org>,
Unicorn Chang <uchang@tw.ibm.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Doug Maxey <dwm@bebe.enoyolf.org>
Subject: libata new EH issue - ATAPI device error not properly reported
Date: Wed, 28 Jun 2006 16:27:34 +0800 [thread overview]
Message-ID: <44A23D76.30307@tw.ibm.com> (raw)
Hi Tejun,
Unicorn is doing some test with the current upstream branch and something
looks strange in the log.
With the new EH, when the ATAPI device reports dev_status 0x51,
the err_mask is reported as 0x0. This does not look right.
Maybe we should report AC_ERR_DEV error back to the upper layers?
(Test log attached for your review.)
--
albert
============================================================================================
(Test log with new EH.
Error transaction with 0x51 dev_status)
Jun 27 18:10:57 xlinux19 kernel: ata_scsi_dump_cdb: CDB (3:0,0,0) 1e 00 00 00 01 00 00 00 00
Jun 27 18:10:57 xlinux19 kernel: ata_scsi_translate: ENTER
Jun 27 18:10:57 xlinux19 kernel: ata3: ata_dev_select: ENTER, ata3: device 0, wait 1
Jun 27 18:10:57 xlinux19 kernel: ata_tf_load_pio: feat 0x0 nsect 0x0 lba 0x0 0x0 0x20
Jun 27 18:10:57 xlinux19 kernel: ata_tf_load_pio: device 0xA0
Jun 27 18:10:57 xlinux19 kernel: ata_exec_command_pio: ata3: cmd 0xA0
Jun 27 18:10:57 xlinux19 kernel: ata_scsi_translate: EXIT
Jun 27 18:10:57 xlinux19 kernel: ata_host_intr: ata3: protocol 6 task_state 5
Jun 27 18:10:57 xlinux19 kernel: ata_hsm_move: ata3: protocol 6 task_state 5 (dev_stat 0x58)
Jun 27 18:10:57 xlinux19 kernel: atapi_send_cdb: send cdb
Jun 27 18:10:57 xlinux19 kernel: ata_host_intr: ata3: protocol 6 task_state 3
Jun 27 18:10:57 xlinux19 kernel: ata_hsm_move: ata3: protocol 6 task_state 3 (dev_stat 0x51) <== device cannot do it
Jun 27 18:10:57 xlinux19 kernel: ata_hsm_move: ata3: protocol 6 task_state 4 (dev_stat 0x51)
Jun 27 18:10:57 xlinux19 kernel: ata_scsi_timed_out: ENTER
Jun 27 18:10:57 xlinux19 kernel: ata_scsi_timed_out: EXIT, ret=0
Jun 27 18:10:57 xlinux19 kernel: ata_scsi_error: ENTER
Jun 27 18:10:57 xlinux19 kernel: ata_port_flush_task: ENTER
Jun 27 18:10:57 xlinux19 kernel: ata_port_flush_task: flush #1
Jun 27 18:10:57 xlinux19 kernel: ata_eh_autopsy: ENTER
Jun 27 18:10:57 xlinux19 kernel: atapi_eh_request_sense: ATAPI request sense
Jun 27 18:10:57 xlinux19 kernel: ata3: ata_dev_select: ENTER, ata3: device 0, wait 1
Jun 27 18:10:57 xlinux19 kernel: ata_tf_load_pio: feat 0x64 nsect 0x3 lba 0x0 0x0 0x20
Jun 27 18:10:57 xlinux19 kernel: ata_tf_load_pio: device 0xA0
Jun 27 18:10:57 xlinux19 kernel: ata_exec_command_pio: ata3: cmd 0xA0
Jun 27 18:10:57 xlinux19 kernel: ata_host_intr: ata3: protocol 5 task_state 5
Jun 27 18:10:57 xlinux19 kernel: ata_hsm_move: ata3: protocol 5 task_state 5 (dev_stat 0x58)
Jun 27 18:10:57 xlinux19 kernel: atapi_send_cdb: send cdb
Jun 27 18:10:57 xlinux19 kernel: ata_host_intr: ata3: protocol 5 task_state 2
Jun 27 18:10:57 xlinux19 kernel: ata_hsm_move: ata3: protocol 5 task_state 2 (dev_stat 0x58)
Jun 27 18:10:57 xlinux19 kernel: atapi_pio_bytes: ata3: xfering 18 bytes
Jun 27 18:10:57 xlinux19 kernel: __atapi_pio_bytes: data read
Jun 27 18:10:57 xlinux19 kernel: ata_host_intr: ata3: protocol 5 task_state 2
Jun 27 18:10:57 xlinux19 kernel: ata_hsm_move: ata3: protocol 5 task_state 2 (dev_stat 0x50)
Jun 27 18:10:57 xlinux19 kernel: ata_hsm_move: ata3: protocol 5 task_state 3 (dev_stat 0x50)
Jun 27 18:10:57 xlinux19 kernel: ata_hsm_move: ata3: dev 0 command complete, drv_stat 0x50
Jun 27 18:10:57 xlinux19 kernel: ata_port_flush_task: ENTER
Jun 27 18:10:57 xlinux19 kernel: ata_port_flush_task: flush #1
Jun 27 18:10:57 xlinux19 kernel: ata_eh_autopsy: EXIT
Jun 27 18:10:57 xlinux19 kernel: ata_eh_recover: ENTER
Jun 27 18:10:57 xlinux19 kernel: ata_eh_revalidate_and_attach: ENTER
Jun 27 18:10:57 xlinux19 kernel: ata_eh_revalidate_and_attach: EXIT
Jun 27 18:10:57 xlinux19 kernel: ata_eh_recover: EXIT, rc=0
Jun 27 18:10:57 xlinux19 kernel: atapi_qc_complete: ENTER, err_mask 0x0 <== Doesn't look right. Should report error.
Jun 27 18:10:57 xlinux19 kernel: ata_scsi_error: EXIT
===============================================================================================
(Test log with new EH.
Normal transaction.)
Jun 27 18:11:02 xlinux19 kernel: ata_scsi_dump_cdb: CDB (3:0,0,0) 1e 00 00 00 01 00 00 00 00
Jun 27 18:11:02 xlinux19 kernel: ata_scsi_translate: ENTER
Jun 27 18:11:02 xlinux19 kernel: ata3: ata_dev_select: ENTER, ata3: device 0, wait 1
Jun 27 18:11:02 xlinux19 kernel: ata_tf_load_pio: feat 0x0 nsect 0x0 lba 0x0 0x0 0x20
Jun 27 18:11:02 xlinux19 kernel: ata_tf_load_pio: device 0xA0
Jun 27 18:11:02 xlinux19 kernel: ata_exec_command_pio: ata3: cmd 0xA0
Jun 27 18:11:02 xlinux19 kernel: ata_scsi_translate: EXIT
Jun 27 18:11:02 xlinux19 kernel: ata_host_intr: ata3: protocol 6 task_state 5
Jun 27 18:11:02 xlinux19 kernel: ata_hsm_move: ata3: protocol 6 task_state 5 (dev_stat 0x58)
Jun 27 18:11:02 xlinux19 kernel: atapi_send_cdb: send cdb
Jun 27 18:11:02 xlinux19 kernel: ata_host_intr: ata3: protocol 6 task_state 3
Jun 27 18:11:02 xlinux19 kernel: ata_hsm_move: ata3: protocol 6 task_state 3 (dev_stat 0x50)
Jun 27 18:11:02 xlinux19 kernel: ata_hsm_move: ata3: dev 0 command complete, drv_stat 0x50
Jun 27 18:11:02 xlinux19 kernel: atapi_qc_complete: ENTER, err_mask 0x0 <== Everything is fine.
next reply other threads:[~2006-06-28 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 8:27 Albert Lee [this message]
2006-06-28 10:27 ` libata new EH issue - ATAPI device error not properly reported Tejun Heo
2006-06-28 11:03 ` Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A23D76.30307@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertl@mail.com \
--cc=dwm@bebe.enoyolf.org \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=uchang@tw.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).