From: Tejun Heo <htejun@gmail.com>
To: albertl@mail.com
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Brian King <brking@us.ibm.com>, Doug Maxey <dwm@bebe.enoyolf.org>,
Unicorn Chang <uchang@tw.ibm.com>
Subject: Re: [PATCH] libata: add host_set->next for legacy two host_sets case, take #3
Date: Wed, 28 Jun 2006 19:42:17 +0900 [thread overview]
Message-ID: <44A25D09.4060705@gmail.com> (raw)
In-Reply-To: <44A25979.3020709@tw.ibm.com>
Albert Lee wrote:
> Hmm, the current patch looks more like a temporary solution. The legacy mode
> ATA_HOST_SIMPLEX host_set->flags could be assigned to both legacy ports.
> In the long term, have one host_set for both legacy ports
> instead of two host_sets for both legacy ports can fix the problem.
>
> A patch was submitted by Unicorn, but it looks not good/elegant enough. :(
> It will be nice if you have plan for furthur legacy two host_sets case fixes...
Hello, Albert.
Yeap, this host_set->next thing is a temporary solution and we need to
handle legacy ports in one host_set. I've seen Unicorn's patches. I
agree that those are in the right direction but we seem to need more
clean up in driver initialization code. I'll look into it once the next
iteration of PMP patches are finished.
Thanks.
--
tejun
next prev parent reply other threads:[~2006-06-28 10:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-12 5:17 [PATCH] libata: add host_set->next for legacy two host sets case Tejun Heo
2006-06-12 6:55 ` Jeff Garzik
2006-06-12 7:06 ` Tejun Heo
2006-06-12 10:14 ` [PATCH] libata: add host_set->next for legacy two host_sets case, take #2 Tejun Heo
2006-06-12 13:35 ` Jeff Garzik
2006-06-12 13:44 ` Tejun Heo
2006-06-12 14:05 ` [PATCH] libata: add host_set->next for legacy two host_sets case, take #3 Tejun Heo
2006-06-12 14:24 ` Jeff Garzik
2006-06-28 10:27 ` Albert Lee
2006-06-28 10:42 ` Tejun Heo [this message]
2006-06-28 10:53 ` Albert Lee
2006-06-28 16:25 ` Alan Cox
2006-06-28 11:38 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A25D09.4060705@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertl@mail.com \
--cc=brking@us.ibm.com \
--cc=dwm@bebe.enoyolf.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=uchang@tw.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).