From: Tejun Heo <htejun@gmail.com>
To: Borislav Petkov <bbpetkov@yahoo.de>
Cc: linux-ide <linux-ide@vger.kernel.org>, Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH 2/9] ahci.c conversion
Date: Fri, 30 Jun 2006 01:30:17 +0900 [thread overview]
Message-ID: <44A40019.1090905@gmail.com> (raw)
In-Reply-To: <20060629160938.GC23122@zmei.tnic>
Borislav Petkov wrote:
> This converts the relevant places of ahci.c to the new scheme.
>
> Signed-off-by: <petkov@math.uni-muenster.de>
>
> --- libata-dev/drivers/scsi/ahci.c.orig 2006-06-28 09:13:10.000000000 +0200
> +++ libata-dev/drivers/scsi/ahci.c 2006-06-29 17:29:06.000000000 +0200
> @@ -617,10 +617,10 @@ static int ahci_softreset(struct ata_por
> u8 *fis;
> int rc;
>
> - DPRINTK("ENTER\n");
> + ata_port_printk(ap, ATA_MSG_TRACE, "%s: ENTER\n", __FUNCTION__);
>
> if (ata_port_offline(ap)) {
> - DPRINTK("PHY reports no device\n");
> + ata_port_printk(ap, ATA_MSG_CMD, "PHY reports no device\n");
Not really CMD, I think it should be ATA_MSG_DEBUG.
<--snip-->
> if (ata_ratelimit())
> - ata_port_printk(ap, KERN_INFO, "spurious interrupt "
> + ata_port_printk(ap, ATA_MSG_DRV, "spurious interrupt "
> "(irq_stat 0x%x active_tag %d sactive 0x%x)\n",
> status, ap->active_tag, ap->sactive);
I don't really understand why it should be DRV not INFO. Is this to
discern between core and LLD messages?
--
tejun
next prev parent reply other threads:[~2006-06-29 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-29 16:09 [PATCH 2/9] ahci.c conversion Borislav Petkov
2006-06-29 16:30 ` Tejun Heo [this message]
2006-06-29 17:00 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2006-06-30 6:45 Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A40019.1090905@gmail.com \
--to=htejun@gmail.com \
--cc=bbpetkov@yahoo.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox