From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: lkml@rtr.ca, axboe@suse.de, forrest.zhao@intel.com,
alan@lxorguk.ukuu.org.uk, linux-ide@vger.kernel.org
Subject: Re: [PATCHSET] new Power Management for libata, take 3
Date: Fri, 30 Jun 2006 12:44:17 -0400 [thread overview]
Message-ID: <44A554E1.6000601@pobox.com> (raw)
In-Reply-To: <11514757842728-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> Hello, all.
>
> This is the third take of new-power-management patchset. Changes from
> the last take[1] are...
>
> * Patches #1-7 are merged to #upstream and thus dropped from this
> patchset.
>
> * libata-reimplement-controller-wide-PM patch has been reimplemented
> to include support for ap->port_suspend() and ap->port_resume().
OK, two minor changes, and I'm ready to pull this.
1) Create ap->dflags or similar, for dynamic port flags. We shouldn't
waste too much time worrying about port flag bits, since they apparently
change all the time anyway :) Just create a second variable for the
overflow, and start moving flags that drivers never see into there.
2) Ditch patch #3, I think ata_flush_cache() is more appropriate in
libata-core, in case other users appear.
prev parent reply other threads:[~2006-06-30 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 6:23 [PATCHSET] new Power Management for libata, take 3 Tejun Heo
2006-06-28 6:23 ` [PATCH 1/8] libata: implement PM EH actions Tejun Heo
2006-06-28 6:23 ` [PATCH 2/8] libata: reimplement per-dev PM Tejun Heo
2006-06-28 6:23 ` [PATCH 4/8] libata: reimplement controller-wide PM Tejun Heo
2006-06-28 6:23 ` [PATCH 5/8] sata_sil: separate out sil_init_controller() Tejun Heo
2006-06-28 6:23 ` [PATCH 3/8] libata: move ata_flush_cache() from libata-core.c to libata-eh.c Tejun Heo
2006-06-28 6:23 ` [PATCH 7/8] sata_sil24: separate out sil24_init_controller() Tejun Heo
2006-06-28 6:23 ` [PATCH 6/8] sata_sil: add suspend/sleep support Tejun Heo
2006-06-28 6:23 ` [PATCH 8/8] sata_sil24: " Tejun Heo
2006-06-28 6:27 ` [git-patches] new Power Management for libata, take 3 Tejun Heo
2006-06-30 16:44 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A554E1.6000601@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=forrest.zhao@intel.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=lkml@rtr.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).