* [PATCH] sata_vsc: data_xfer should use mmio
@ 2006-06-28 16:17 Martin Hicks
2006-07-06 1:44 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Martin Hicks @ 2006-06-28 16:17 UTC (permalink / raw)
To: jgarzik, linux-ide
Hi,
sata_vsc is an MMIO device, and should use the correct data_xfer
function. This problem was introduced by:
commit a6b2c5d4754dc539a560fdf0d3fb78a14174394a
Author: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Mon May 22 16:59:59 2006 +0100
[PATCH] PATCH: libata. Add ->data_xfer method
Signed-off-by: Martin Hicks <mort@bork.org>
---
drivers/scsi/sata_vsc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
e00c172b64186a6ff08e7f09086f89bedac4cc6d
diff --git a/drivers/scsi/sata_vsc.c b/drivers/scsi/sata_vsc.c
index 6d0c4f1..d97af87 100644
--- a/drivers/scsi/sata_vsc.c
+++ b/drivers/scsi/sata_vsc.c
@@ -297,7 +297,7 @@ static const struct ata_port_operations
.bmdma_status = ata_bmdma_status,
.qc_prep = ata_qc_prep,
.qc_issue = ata_qc_issue_prot,
- .data_xfer = ata_pio_data_xfer,
+ .data_xfer = ata_mmio_data_xfer,
.freeze = ata_bmdma_freeze,
.thaw = ata_bmdma_thaw,
.error_handler = ata_bmdma_error_handler,
--
1.3.2
--
Martin Hicks || mort@bork.org || PGP/GnuPG: 0x4C7F2BEE
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sata_vsc: data_xfer should use mmio
2006-06-28 16:17 [PATCH] sata_vsc: data_xfer should use mmio Martin Hicks
@ 2006-07-06 1:44 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-07-06 1:44 UTC (permalink / raw)
To: Martin Hicks; +Cc: linux-ide
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-07-06 1:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-28 16:17 [PATCH] sata_vsc: data_xfer should use mmio Martin Hicks
2006-07-06 1:44 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).