* [PATCH] libata: fix ehc->i.action setting in ata_eh_autopsy()
@ 2006-07-02 17:54 Tejun Heo
2006-07-06 2:01 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2006-07-02 17:54 UTC (permalink / raw)
To: Jeff Garzik, linux-ide
ata_eh_autopsy() used to directly assign determined action mask to
ehc->i.action thus overriding actions set by some of nested analyze
functions. This patch makes ata_eh_autopsy() add action masks just as
it's done in other places.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
Jeff, this doesn't cause too much trouble but it would be nice to have
this fixed in #linus too. Thanks.
drivers/scsi/libata-eh.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
fda815b4e76189eda0fb6e9fab60fe191c9e019a
diff --git a/drivers/scsi/libata-eh.c b/drivers/scsi/libata-eh.c
index f2f29a8..4a670db 100644
--- a/drivers/scsi/libata-eh.c
+++ b/drivers/scsi/libata-eh.c
@@ -1346,7 +1346,7 @@ static void ata_eh_autopsy(struct ata_po
/* record autopsy result */
ehc->i.dev = failed_dev;
- ehc->i.action = action;
+ ehc->i.action |= action;
DPRINTK("EXIT\n");
}
--
1.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-07-06 2:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-02 17:54 [PATCH] libata: fix ehc->i.action setting in ata_eh_autopsy() Tejun Heo
2006-07-06 2:01 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).