From: Jeff Garzik <jeff@garzik.org>
To: akpm@osdl.org, Jason Gaston <jason.d.gaston@intel.com>
Cc: helms.adam@gmail.com, htejun@gmail.com,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: + sata-add-pci-id.patch added to -mm tree
Date: Wed, 12 Jul 2006 13:46:54 -0400 [thread overview]
Message-ID: <44B5358E.4050301@garzik.org> (raw)
In-Reply-To: <200607090039.k690d4j0005100@shell0.pdx.osdl.net>
akpm@osdl.org wrote:
> Subject: SATA: Add PCI-ID
> From: "Adam Helms" <helms.adam@gmail.com>
>
> Makes the AHCI driver detect the PCI ID 8086:27c0 (IDE interface: Intel
> Corporation 82801GB/GR/GH (ICH7 Family) Serial ATA Storage Controller IDE
> (rev 01)) as an AHCI chipset.
>
> 8086:27c0 also works with ata_piix but it's much slower. 8086:27c0 is
> shipped with - among others - new HP Proliant servers.
> diff -puN drivers/scsi/ahci.c~sata-add-pci-id drivers/scsi/ahci.c
> --- a/drivers/scsi/ahci.c~sata-add-pci-id
> +++ a/drivers/scsi/ahci.c
> @@ -291,6 +291,8 @@ static const struct pci_device_id ahci_p
> board_ahci }, /* ICH6 */
> { PCI_VENDOR_ID_INTEL, 0x2653, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> board_ahci }, /* ICH6M */
> + { PCI_VENDOR_ID_INTEL, 0x27c0, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> + board_ahci }, /* ICH7 */
> { PCI_VENDOR_ID_INTEL, 0x27c1, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> board_ahci }, /* ICH7 */
> { PCI_VENDOR_ID_INTEL, 0x27c5, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
This patch needs discussing with Intel.
0x27c0 was intentionally omitted, because it is only supposed to show up
when the device is configured into IDE mode.
If the user (read: BIOS) has chosen to configure the device in AHCI
mode, it should show up as a different PCI ID, which ahci.c already
contains.
I'm inclined to NAK the patch, since things appear to be working as
expected.
Jeff
next parent reply other threads:[~2006-07-12 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200607090039.k690d4j0005100@shell0.pdx.osdl.net>
2006-07-12 17:46 ` Jeff Garzik [this message]
2006-07-12 18:04 + sata-add-pci-id.patch added to -mm tree Gaston, Jason D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B5358E.4050301@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=helms.adam@gmail.com \
--cc=htejun@gmail.com \
--cc=jason.d.gaston@intel.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).