From: Jeff Garzik <jeff@garzik.org>
To: John Keller <jpk@sgi.com>
Cc: Jeremy Higdon <jeremy@sgi.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/1] - sgiioc4: fixup use of mmio ops
Date: Thu, 13 Jul 2006 10:45:40 -0400 [thread overview]
Message-ID: <44B65C94.6040100@garzik.org> (raw)
In-Reply-To: <200607131354.k6DDsaqe064559@fcbayern.americas.sgi.com>
John Keller wrote:
>>>> - if (!request_region(base, IOC4_CMD_CTL_BLK_SIZE, hwif->name)) {
>>>> + cmd_phys_base = bar0 + IOC4_CMD_OFFSET;
>>>> + if (!request_mem_region(cmd_phys_base, IOC4_CMD_CTL_BLK_SIZE,
>>>> + hwif->name)) {
>>>> printk(KERN_ERR
>>>> - "%s : %s -- ERROR, Port Addresses "
>>>> + "%s : %s -- ERROR, Addresses "
>>>> "0x%p to 0x%p ALREADY in use\n",
>>>> - __FUNCTION__, hwif->name, (void *) base,
>>>> - (void *) base + IOC4_CMD_CTL_BLK_SIZE);
>>>> + __FUNCTION__, hwif->name, (void *) cmd_phys_base,
>>>> + (void *) cmd_phys_base + IOC4_CMD_CTL_BLK_SIZE);
>> If 'void __iomem *' were used, no casts would be needed here
>
> So, 'void __iomem *' should also be used for physical (non-mapped)
> addresses, as in this case?
Ooops, no, just cookies returned from ioremap() and ioremap_nocache().
Jeff
next prev parent reply other threads:[~2006-07-13 14:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-12 17:57 [PATCH 1/1] - sgiioc4: fixup use of mmio ops John Keller
2006-07-12 19:52 ` Jeremy Higdon
2006-07-12 20:36 ` Jeff Garzik
2006-07-13 13:54 ` John Keller
2006-07-13 14:45 ` Jeff Garzik [this message]
2006-07-12 23:11 ` Brent Casavant
-- strict thread matches above, loose matches on Subject: below --
2006-07-19 15:31 John Keller
2006-07-20 5:19 ` Jeremy Higdon
2006-07-21 13:16 ` Andrew Morton
2006-07-24 13:56 John Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B65C94.6040100@garzik.org \
--to=jeff@garzik.org \
--cc=jeremy@sgi.com \
--cc=jpk@sgi.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).