From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] avoid releasing twice the same region on ide_release_iomio_dma()
Date: Mon, 24 Jul 2006 23:58:05 +0400 [thread overview]
Message-ID: <44C5264D.4040609@ru.mvista.com> (raw)
In-Reply-To: <20060724193031.GA18463@cathedrallabs.org>
Hello.
Aristeu Sergio Rozanski Filho wrote:
> In ide_release_iomio_dma() it's possible to release twice
> hwif->dma_base if hwif->dma_base2 is not null and never releasing
> hwif->dma_base2:
> int ide_release_iomio_dma (ide_hwif_t *hwif)
> {
> if ((hwif->dma_extra) && (hwif->channel == 0))
> release_region((hwif->dma_base + 16), hwif->dma_extra);
> release_region(hwif->dma_base, 8);
> if (hwif->dma_base2)
> release_region(hwif->dma_base, 8);
> ^^^^^^^^^
> return 1;
> }
> This patch fixes this typo.
> Signed-off-by: Aristeu S. Rozanski F. <aris@cathedrallabs.org>
>
> Index: ppc-2.6/drivers/ide/ide-dma.c
> ===================================================================
> --- ppc-2.6.orig/drivers/ide/ide-dma.c 2006-07-24 12:25:20.000000000 -0300
> +++ ppc-2.6/drivers/ide/ide-dma.c 2006-07-24 12:26:26.000000000 -0300
> @@ -802,7 +802,7 @@
> release_region((hwif->dma_base + 16), hwif->dma_extra);
> release_region(hwif->dma_base, 8);
> if (hwif->dma_base2)
> - release_region(hwif->dma_base, 8);
> + release_region(hwif->dma_base2, 8);
> return 1;
> }
dma_base2 should go away altogether -- this is the IDE maintainer's opinion:
http://marc.theaimsgroup.com/?l=linux-ide&m=114345699807546&w=2
I have posted this patch doing this back in March:
http://marc.theaimsgroup.com/?l=linux-ide&m=114357441529834&w=2
and it was in the -mm tree for some months but has been removed recently -- I
still need to coordinate it with SGI.
WBR, Sergei
next prev parent reply other threads:[~2006-07-24 19:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-24 19:30 [PATCH] avoid releasing twice the same region on ide_release_iomio_dma() Aristeu Sergio Rozanski Filho
2006-07-24 19:58 ` Sergei Shtylyov [this message]
2006-07-24 20:14 ` Aristeu Sergio Rozanski Filho
2006-07-24 21:23 ` Greg Freemyer
2006-07-25 12:22 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44C5264D.4040609@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=aris@cathedrallabs.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).