From: Unicorn Chang <uchang@tw.ibm.com>
To: Jeff Garzik <jgarzik@pobox.com>, linux-ide@vger.kernel.org
Subject: [PATCH] ahci: skip protocol test altogether in spurious interrupt code
Date: Tue, 01 Aug 2006 12:18:07 +0800 [thread overview]
Message-ID: <44CED5FF.6090701@tw.ibm.com> (raw)
Skip protocol test altogether in spurious interrupt code. If PIOS is received
when it shouldn't, ahci will raise protocol violation.
Signed-off-by: Unicorn Chang <uchang@tw.ibm.com>
---
Patch for kernel bug 6826 - GoVault spurious interrupts
(http://bugzilla.kernel.org/show_bug.cgi?id=6826)
--- linux-2.6.18-rc2/drivers/scsi/ahci.c.orig 2006-07-24 14:40:41.000000000 -0700
+++ linux-2.6.18-rc2/drivers/scsi/ahci.c 2006-07-31 10:49:30.000000000 -0700
@@ -940,14 +940,8 @@ static void ahci_host_intr(struct ata_po
return;
/* ignore interim PIO setup fis interrupts */
- if (ata_tag_valid(ap->active_tag)) {
- struct ata_queued_cmd *qc =
- ata_qc_from_tag(ap, ap->active_tag);
-
- if (qc && qc->tf.protocol == ATA_PROT_PIO &&
- (status & PORT_IRQ_PIOS_FIS))
- return;
- }
+ if (ata_tag_valid(ap->active_tag) && (status & PORT_IRQ_PIOS_FIS))
+ return;
if (ata_ratelimit())
ata_port_printk(ap, KERN_INFO, "spurious interrupt "
next reply other threads:[~2006-08-01 4:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 4:18 Unicorn Chang [this message]
2006-08-01 10:12 ` [PATCH] ahci: skip protocol test altogether in spurious interrupt code Tejun Heo
2006-08-03 21:35 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44CED5FF.6090701@tw.ibm.com \
--to=uchang@tw.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).