linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ahci: skip protocol test altogether in spurious interrupt code
@ 2006-08-01  4:18 Unicorn Chang
  2006-08-01 10:12 ` Tejun Heo
  2006-08-03 21:35 ` Jeff Garzik
  0 siblings, 2 replies; 3+ messages in thread
From: Unicorn Chang @ 2006-08-01  4:18 UTC (permalink / raw)
  To: Jeff Garzik, linux-ide


Skip protocol test altogether in spurious interrupt code. If PIOS is received
when it shouldn't, ahci will raise protocol violation.

Signed-off-by: Unicorn Chang <uchang@tw.ibm.com>
---

Patch for kernel bug 6826 - GoVault spurious interrupts
(http://bugzilla.kernel.org/show_bug.cgi?id=6826)

--- linux-2.6.18-rc2/drivers/scsi/ahci.c.orig	2006-07-24 14:40:41.000000000 -0700
+++ linux-2.6.18-rc2/drivers/scsi/ahci.c	2006-07-31 10:49:30.000000000 -0700
@@ -940,14 +940,8 @@ static void ahci_host_intr(struct ata_po
 		return;
 
 	/* ignore interim PIO setup fis interrupts */
-	if (ata_tag_valid(ap->active_tag)) {
-		struct ata_queued_cmd *qc =
-			ata_qc_from_tag(ap, ap->active_tag);
-
-		if (qc && qc->tf.protocol == ATA_PROT_PIO &&
-		    (status & PORT_IRQ_PIOS_FIS))
-			return;
-	}
+	if (ata_tag_valid(ap->active_tag) && (status & PORT_IRQ_PIOS_FIS)) 
+		return;
 
 	if (ata_ratelimit())
 		ata_port_printk(ap, KERN_INFO, "spurious interrupt "


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-08-03 21:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-01  4:18 [PATCH] ahci: skip protocol test altogether in spurious interrupt code Unicorn Chang
2006-08-01 10:12 ` Tejun Heo
2006-08-03 21:35 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).