From: Jeff Garzik <jgarzik@pobox.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org, akpm@osdl.org
Subject: Re: PATCH: Add full Compact Flash support to libata
Date: Tue, 08 Aug 2006 23:42:27 -0400 [thread overview]
Message-ID: <44D959A3.1090908@pobox.com> (raw)
In-Reply-To: <1154016810.13509.61.camel@localhost.localdomain>
ACK, but patch doesn't apply to libata-core.c.
Also, git-applymbox complains that you add trailing whitespace:
>
> [jgarzik@pretzel libata-dev]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt
> 1 patch(es) to process.
>
> Applying 'Add full Compact Flash support to libata'
>
> Adds trailing whitespace.
> .dotest/patch:119: { XFER_PIO_6, 10, 55, 20, 80, 55, 20, 80, 0 },
> Adds trailing whitespace.
> .dotest/patch:120: { XFER_PIO_5, 15, 65, 25, 100, 65, 25, 100, 0 },
> Adds trailing whitespace.
> .dotest/patch:190: if (ata_id_major_version(id) >= 3 && id[82] != 0xFFFF &&
> Adds trailing whitespace.
> .dotest/patch:195:
> error: patch failed: drivers/scsi/libata-core.c:3073
> error: drivers/scsi/libata-core.c: patch does not apply
prev parent reply other threads:[~2006-08-09 3:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-27 16:13 PATCH: Add full Compact Flash support to libata Alan Cox
2006-07-27 17:41 ` Mark Lord
2006-07-27 18:04 ` Alan Cox
2006-07-27 17:55 ` Mark Lord
2006-08-09 3:42 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D959A3.1090908@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).