* [PATCH] ahci: remove IRQ mask clearing from init_controller() @ 2006-08-07 2:39 Tejun Heo 2006-08-09 3:51 ` Jeff Garzik 2006-08-09 4:16 ` Jeff Garzik 0 siblings, 2 replies; 4+ messages in thread From: Tejun Heo @ 2006-08-07 2:39 UTC (permalink / raw) To: Jeff Garzik, linux-ide Initial IRQ mask clearing is done by libata-core by freezing all ports prior to requesting IRQ. Remove redundant IRQ clearing from init_controller(). Signed-off-by: Tejun Heo <htejun@gmail.com> --- drivers/scsi/ahci.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) 049892ed973dc00569e26130826fef0000fc7577 diff --git a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c index f5734a9..68fd766 100644 --- a/drivers/scsi/ahci.c +++ b/drivers/scsi/ahci.c @@ -662,14 +662,13 @@ #endif VPRINTK("PORT_SCR_ERR 0x%x\n", tmp); writel(tmp, port_mmio + PORT_SCR_ERR); - /* clear & turn off port IRQ */ + /* clear port IRQ */ tmp = readl(port_mmio + PORT_IRQ_STAT); VPRINTK("PORT_IRQ_STAT 0x%x\n", tmp); if (tmp) writel(tmp, port_mmio + PORT_IRQ_STAT); writel(1 << i, mmio + HOST_IRQ_STAT); - writel(0, port_mmio + PORT_IRQ_MASK); } tmp = readl(mmio + HOST_CTL); -- 1.3.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ahci: remove IRQ mask clearing from init_controller() 2006-08-07 2:39 [PATCH] ahci: remove IRQ mask clearing from init_controller() Tejun Heo @ 2006-08-09 3:51 ` Jeff Garzik 2006-08-09 4:01 ` Tejun Heo 2006-08-09 4:16 ` Jeff Garzik 1 sibling, 1 reply; 4+ messages in thread From: Jeff Garzik @ 2006-08-09 3:51 UTC (permalink / raw) To: Tejun Heo; +Cc: linux-ide Tejun Heo wrote: > Initial IRQ mask clearing is done by libata-core by freezing all ports > prior to requesting IRQ. Remove redundant IRQ clearing from > init_controller(). > > Signed-off-by: Tejun Heo <htejun@gmail.com> is this for upstream (2.6.19) or upstream-fixes (2.6.18-rc)? Jeff ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ahci: remove IRQ mask clearing from init_controller() 2006-08-09 3:51 ` Jeff Garzik @ 2006-08-09 4:01 ` Tejun Heo 0 siblings, 0 replies; 4+ messages in thread From: Tejun Heo @ 2006-08-09 4:01 UTC (permalink / raw) To: Jeff Garzik; +Cc: linux-ide Jeff Garzik wrote: > Tejun Heo wrote: >> Initial IRQ mask clearing is done by libata-core by freezing all ports >> prior to requesting IRQ. Remove redundant IRQ clearing from >> init_controller(). >> >> Signed-off-by: Tejun Heo <htejun@gmail.com> > > is this for upstream (2.6.19) or upstream-fixes (2.6.18-rc)? It's for #upstream. -- tejun ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ahci: remove IRQ mask clearing from init_controller() 2006-08-07 2:39 [PATCH] ahci: remove IRQ mask clearing from init_controller() Tejun Heo 2006-08-09 3:51 ` Jeff Garzik @ 2006-08-09 4:16 ` Jeff Garzik 1 sibling, 0 replies; 4+ messages in thread From: Jeff Garzik @ 2006-08-09 4:16 UTC (permalink / raw) To: Tejun Heo; +Cc: linux-ide applied ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-08-09 4:16 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2006-08-07 2:39 [PATCH] ahci: remove IRQ mask clearing from init_controller() Tejun Heo 2006-08-09 3:51 ` Jeff Garzik 2006-08-09 4:01 ` Tejun Heo 2006-08-09 4:16 ` Jeff Garzik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).