From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: alan@lxorguk.ukuu.org.uk, mlord@pobox.com, albertcc@tw.ibm.com,
uchang@tw.ibm.com, forrest.zhao@intel.com,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 01/17] libata: implement ata_host_set_start/stop()
Date: Wed, 09 Aug 2006 00:57:49 -0400 [thread overview]
Message-ID: <44D96B4D.5080103@pobox.com> (raw)
In-Reply-To: <11549198402749-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> --- a/include/linux/libata.h
> +++ b/include/linux/libata.h
> @@ -174,13 +174,14 @@ enum {
> /* bits 24:31 of ap->flags are reserved for LLD specific flags */
>
> /* struct ata_port pflags */
> - ATA_PFLAG_EH_PENDING = (1 << 0), /* EH pending */
> - ATA_PFLAG_EH_IN_PROGRESS = (1 << 1), /* EH in progress */
> - ATA_PFLAG_FROZEN = (1 << 2), /* port is frozen */
> - ATA_PFLAG_RECOVERED = (1 << 3), /* recovery action performed */
> - ATA_PFLAG_LOADING = (1 << 4), /* boot/loading probe */
> - ATA_PFLAG_UNLOADING = (1 << 5), /* module is unloading */
> - ATA_PFLAG_SCSI_HOTPLUG = (1 << 6), /* SCSI hotplug scheduled */
> + ATA_PFLAG_STARTED = (1 << 0), /* port has been started */
> + ATA_PFLAG_EH_PENDING = (1 << 1), /* EH pending */
> + ATA_PFLAG_EH_IN_PROGRESS = (1 << 2), /* EH in progress */
> + ATA_PFLAG_FROZEN = (1 << 3), /* port is frozen */
> + ATA_PFLAG_RECOVERED = (1 << 4), /* recovery action performed */
> + ATA_PFLAG_LOADING = (1 << 5), /* boot/loading probe */
> + ATA_PFLAG_UNLOADING = (1 << 6), /* module is unloading */
> + ATA_PFLAG_SCSI_HOTPLUG = (1 << 7), /* SCSI hotplug scheduled */
>
Please don't obscure your change by all this bit renumbering.
Otherwise OK
next prev parent reply other threads:[~2006-08-09 4:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 3:03 [PATCHSET] libata: implement new initialization model w/ iomap support Tejun Heo
2006-08-07 3:04 ` [PATCH 06/17] libata: reimplement ata_pci_init_one() using new init helpers Tejun Heo
2006-08-07 3:04 ` [PATCH 02/17] libata: implement ata_host_set_detach() and ata_host_set_free() Tejun Heo
2006-08-09 4:59 ` Jeff Garzik
2006-08-07 3:04 ` [PATCH 01/17] libata: implement ata_host_set_start/stop() Tejun Heo
2006-08-09 4:57 ` Jeff Garzik [this message]
2006-08-07 3:04 ` [PATCH 03/17] libata: separate out ata_host_set_alloc() and ata_host_set_attach() Tejun Heo
2006-08-09 5:00 ` Jeff Garzik
2006-08-07 3:04 ` [PATCH 04/17] libata: implement several LLD init helpers Tejun Heo
2006-08-09 5:01 ` Jeff Garzik
2006-08-09 5:08 ` Tejun Heo
2006-08-07 3:04 ` [PATCH 05/17] libata: implement PCI init helpers for new LLD init model Tejun Heo
2006-08-09 5:11 ` Jeff Garzik
2006-08-09 5:52 ` Tejun Heo
2006-08-09 6:41 ` Jeff Garzik
2006-08-09 11:00 ` Alan Cox
2006-08-10 7:12 ` Albert Lee
2006-08-10 7:27 ` Jeff Garzik
2006-08-10 12:36 ` Alan Cox
2006-08-10 12:22 ` Tejun Heo
2006-08-09 12:54 ` Mark Lord
2006-08-09 11:02 ` Alan Cox
2006-08-09 11:13 ` Tejun Heo
2006-08-07 3:04 ` [PATCH 10/17] libata: kill old init helpers Tejun Heo
2006-08-07 3:04 ` [PATCH 09/17] libata: use remove_one() for deinit instead of ->host_stop() Tejun Heo
2006-08-07 3:04 ` [PATCH 08/17] libata: update ata_pci_remove_one() using new PCI init helpers Tejun Heo
2006-08-07 3:04 ` [PATCH 11/17] libata: kill unused ->host_stop() operation and related functions Tejun Heo
2006-08-07 3:04 ` [PATCH 13/17] libata: move ->irq_handler from port_ops to port_info Tejun Heo
2006-08-07 3:04 ` [PATCH 12/17] libata: use LLD name where possible Tejun Heo
2006-08-07 3:04 ` [PATCH 15/17] libata: make ata_pci_acquire_resources() handle iomap Tejun Heo
2006-08-07 3:04 ` [PATCH 14/17] libata: make ata_host_set_alloc() take care of hpriv alloc/free Tejun Heo
2006-08-07 3:04 ` [PATCH 17/17] libata: kill unused ATA_FLAG_MMIO Tejun Heo
2006-08-07 3:08 ` [git-patches] libata: implement new initialization model w/ iomap support Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D96B4D.5080103@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=forrest.zhao@intel.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=mlord@pobox.com \
--cc=uchang@tw.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).