* [PATCH] libata: Use ATA_FLAG_PIO_POLLING for pdc_adma
@ 2006-08-09 10:36 Albert Lee
2006-08-09 12:59 ` Mark Lord
2006-08-10 10:55 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Albert Lee @ 2006-08-09 10:36 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linux IDE, Mark Lord, Tejun Heo
pdc_adma was overlooked and broken by the irq-pio patch:
Only HSM_ST_LAST interrupts should be delivered to this LLDD.
Adding ATA_FLAG_PIO_POLLING to pdc_adma fixes the problem (temporarily),
before we convert the irq handler of pdc_adma to handle all interrupts.
Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
---
Patch against 2.6.18-rc4 and tested ok by Tejun.
--- linux-2.6.18-rc4/drivers/scsi/pdc_adma.c 2006-08-08 14:03:21.000000000 +0800
+++ linux-2.6.18-rc4-adma-poll/drivers/scsi/pdc_adma.c 2006-08-08 14:05:13.000000000 +0800
@@ -183,7 +183,8 @@ static struct ata_port_info adma_port_in
{
.sht = &adma_ata_sht,
.host_flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_SRST |
- ATA_FLAG_NO_LEGACY | ATA_FLAG_MMIO,
+ ATA_FLAG_NO_LEGACY | ATA_FLAG_MMIO |
+ ATA_FLAG_PIO_POLLING,
.pio_mask = 0x10, /* pio4 */
.udma_mask = 0x1f, /* udma0-4 */
.port_ops = &adma_ata_ops,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] libata: Use ATA_FLAG_PIO_POLLING for pdc_adma
2006-08-09 10:36 [PATCH] libata: Use ATA_FLAG_PIO_POLLING for pdc_adma Albert Lee
@ 2006-08-09 12:59 ` Mark Lord
2006-08-10 10:55 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Mark Lord @ 2006-08-09 12:59 UTC (permalink / raw)
To: albertl; +Cc: Jeff Garzik, Linux IDE, Tejun Heo
Albert Lee wrote:
> pdc_adma was overlooked and broken by the irq-pio patch:
> Only HSM_ST_LAST interrupts should be delivered to this LLDD.
>
> Adding ATA_FLAG_PIO_POLLING to pdc_adma fixes the problem (temporarily),
> before we convert the irq handler of pdc_adma to handle all interrupts.
>
> Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
Signed-off-by: Mark Lord <mlord@pobox.com>
Looks good. Note also that sata_qstor.c uses the same code structure,
and already does the same thing.
> ---
> Patch against 2.6.18-rc4 and tested ok by Tejun.
>
> --- linux-2.6.18-rc4/drivers/scsi/pdc_adma.c 2006-08-08 14:03:21.000000000 +0800
> +++ linux-2.6.18-rc4-adma-poll/drivers/scsi/pdc_adma.c 2006-08-08 14:05:13.000000000 +0800
> @@ -183,7 +183,8 @@ static struct ata_port_info adma_port_in
> {
> .sht = &adma_ata_sht,
> .host_flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_SRST |
> - ATA_FLAG_NO_LEGACY | ATA_FLAG_MMIO,
> + ATA_FLAG_NO_LEGACY | ATA_FLAG_MMIO |
> + ATA_FLAG_PIO_POLLING,
> .pio_mask = 0x10, /* pio4 */
> .udma_mask = 0x1f, /* udma0-4 */
> .port_ops = &adma_ata_ops,
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] libata: Use ATA_FLAG_PIO_POLLING for pdc_adma
2006-08-09 10:36 [PATCH] libata: Use ATA_FLAG_PIO_POLLING for pdc_adma Albert Lee
2006-08-09 12:59 ` Mark Lord
@ 2006-08-10 10:55 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2006-08-10 10:55 UTC (permalink / raw)
To: albertl; +Cc: Linux IDE, Mark Lord, Tejun Heo
applied to #upstream-fixes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-08-10 10:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-09 10:36 [PATCH] libata: Use ATA_FLAG_PIO_POLLING for pdc_adma Albert Lee
2006-08-09 12:59 ` Mark Lord
2006-08-10 10:55 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).