Re: [PATCH] ide: Reinitilize idedisk_capacity for HPA drives on resume

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Lee Trager wrote:

> This patch fixes a problem that when a computer with HPA on it's hard
> drive comes out of sleep mode it needs the disks capacity reinitialized.

> This is my first patch to the Linux kernel so if I did anything wrong
> please be gentle ;)

    Your mailer spoils tabs, so either attach your patch or use the different
mailer.

[...]

> diff -Naur linux-2.6.18-rc4-old/drivers/ide/ide.c
> linux-2.6.18-rc4/drivers/ide/ide.c
> --- linux-2.6.18-rc4-old/drivers/ide/ide.c    2006-08-19
> 03:49:03.000000000 -0400
> +++ linux-2.6.18-rc4/drivers/ide/ide.c    2006-08-20 19:12:38.000000000
> -0400
> @@ -1232,6 +1232,7 @@
>      struct request rq;
>      struct request_pm_state rqpm;
>      ide_task_t args;
> +    int ide_cmd;
>  
>      memset(&rq, 0, sizeof(rq));
>      memset(&rqpm, 0, sizeof(rqpm));
> @@ -1242,7 +1243,15 @@
>      rqpm.pm_step = ide_pm_state_start_resume;
>      rqpm.pm_state = PM_EVENT_ON;
>  
> -    return ide_do_drive_cmd(drive, &rq, ide_head_wait);
> +    ide_cmd = ide_do_drive_cmd(drive, &rq, ide_head_wait);
> +
> +    /* check to see if this is a hard drive
> +     * if it is then checkhpa needs to be
> +     * disabled */
> +    if(drive->media == ide_disk && idedisk_supports_hpa(drive->id))
> +        init_idedisk_capacity(drive);
> +
> +    return ide_cmd;
>  }

    Hm, shouldn't this be handled as a separate resume process step?

MBR, Sergei