Re: [Fwd: [BUG] sata_via doesn't detect anymore my disks (broken between rc1 and rc3)]

[Tejun Heo <htejun@gmail.com>]

Thierry Vignaud wrote:
> Thierry Vignaud <tvignaud@mandriva.com> writes:
> 
>>> Can you please test two patches attached in this mail?  Just quick
>>> result will be enough.  If both don't work, I'll go ahead and
>>> create a third one - which emulates the old phy hardreset exactly
>>> as I did for softreset of vt6420.
>> I'll.
>>
>> As, I've tested that using:
>> - ata_std_prereset + ata_std_softreset didn't work
>> - vt6420_prereset + ata_std_softreset worked
>> - vt6420_prereset w/o ata_std_softreset didn't work
>>
>> I simple interdiff between your two patches makes me think the odds're
>> higher the second will succeed but you've done some extra changes
>> since your previous patch.
>> I'll you tell you more about this tomorrow.
> 
> none of both these patches worked :-(

The second didn't work?  But you said the following one liner worked.

--- drivers/ata/sata_via.c.tv6	2006-08-20 16:37:41.000000000 +0200
+++ drivers/ata/sata_via.c	2006-08-20 17:20:23.000000000 +0200
@@ -244,7 +244,7 @@

  static void vt6421_error_handler(struct ata_port *ap)
  {
-	return ata_bmdma_drive_eh(ap, ata_std_prereset, NULL,
+	return ata_bmdma_drive_eh(ap, vt6420_prereset, ata_std_softreset,
  				  sata_std_hardreset, ata_std_postreset);
  }

The second patch is essentially identical to what you did the one liner. 
  Can you please check it once more?  I'll prepare old-sequence 
hardreset in the meantime.

Thanks.

-- 
tejun